Fix :tornado (#2124)#2125
Open
thatgato wants to merge 1 commit into
Open
Conversation
Bring the :tornado command back to life by moving the script logic from Core.NewScript() into server dependencies. Notes: - The SoundId had to be replaced due to old, inaccessible sound usage. - The tornado does not appear to have a model. I'm not sure if this is intentional or not, but refer to issue Epix-Incorporated#2124 for more information PoF included in Epix-Incorporated#2124
Contributor
Author
|
Ready for review, but please read the issues with this command when looking at this PR |
ccuser44
suggested changes
May 17, 2026
Contributor
There was a problem hiding this comment.
I reviewed the Adonis code behind this and found out it might actually expected behavior for string scripts not to run if code execution is off. A recent change seems to enforce this restriction which is the reason why the commands stopped working and there's no good UX to tell the user about this. #2137
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring the :tornado command back to life by moving the script logic from Core.NewScript() into server dependencies.
Notes:
PoF included in #2124