feat(api): add PrecomputedConfigParser interface and BasePrecomputedClient#245
Closed
typotter wants to merge 2 commits intofeature/v4-core-upgrade/pr1-module-setupfrom
Closed
Conversation
…lient Create the framework interfaces for precomputed client functionality: - Add PrecomputedConfigParser<T> interface for JSON parsing abstraction - Add PrecomputedParseException for parse error handling - Create BasePrecomputedClient<T> abstract class with core logic - Refactor EppoPrecomputedClient to extend BasePrecomputedClient<JsonNode> This enables framework consumers to provide custom JSON implementations while the batteries-included artifact provides Jackson defaults.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defines the precomputed client interfaces and base class for the framework module:
PrecomputedConfigParser<T>- Interface for parsing precomputed configurationPrecomputedParseException- Exception for parse errorsBasePrecomputedClient<T>- Abstract base class for precomputed clientsChanges
PrecomputedConfigParser<T>interface incloud.eppo.android.apipackagePrecomputedParseExceptionfor parse error handlingBasePrecomputedClient<T>abstract classEppoPrecomputedClientto extendBasePrecomputedClient<JsonNode>Test Plan
./gradlew :eppo:compileDebugJavaWithJavac./gradlew :eppo:testDebugUnitTestConfigurationParserPart of v4 SDK Upgrade
This is PR 2 of the v4 upgrade series. Depends on PR 1 (#244).