test: add empty string subject key validation test#141
Open
leoromanovsky wants to merge 4 commits intomainfrom
Open
test: add empty string subject key validation test#141leoromanovsky wants to merge 4 commits intomainfrom
leoromanovsky wants to merge 4 commits intomainfrom
Conversation
Adds test case to validate SDK behavior when subject key is an empty string. This is a separate policy decision from the falsy value assignment bug - it tests whether SDKs should accept empty string as a valid subject identifier. Test validates: - Empty string subject can get legitimate assignments (not just defaults) - Normal subjects with real keys continue to work - Proper default fallback when no rules match
aarsilv
approved these changes
Nov 4, 2025
Contributor
aarsilv
left a comment
aarsilv
left a comment
There was a problem hiding this comment.
Nice! Approving as-is, with a request to expand the test to test for empty-string-valued attributes (if we're not yet already testing those)
| "defaultValue": true, | ||
| "subjects": [ | ||
| { | ||
| "subjectKey": "", |
| "attribute": "user_type", | ||
| "operator": "ONE_OF", | ||
| "value": [ | ||
| "anonymous" |
Contributor
There was a problem hiding this comment.
This reminds me, if we are not already, we should have these tests check to make sure ONE_OF and NOT_ONE_OF work as expected with empty string values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test case to validate SDK behavior when subject key is an empty string. It tests whether SDKs should accept empty string as a valid subject identifier.
Test validates: