Add protobuf converter for test files and generate pb versions#145
Draft
leoromanovsky wants to merge 5 commits intomainfrom
Draft
Add protobuf converter for test files and generate pb versions#145leoromanovsky wants to merge 5 commits intomainfrom
leoromanovsky wants to merge 5 commits intomainfrom
Conversation
This test demonstrates that null is a valid JSON value that should be returned by SDKs when a JSON flag variation is explicitly set to null. This addresses the issue where checking `if (variant != null)` might incorrectly skip returning null values when null is a legitimate JSON response. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add comprehensive protobuf converter tool for JSON UFC files - Support bulk conversion of all UFC files in ufc/ directory - Add validation tool to verify protobuf binary integrity - Include complete TypeScript DTOs and protobuf bindings - Generate .pb test fixtures from existing JSON UFC files - Achieve 76-82% compression ratio (JSON → protobuf) Features: - Auto-detect and convert valid UFC JSON files - Skip non-UFC files (like bandit models) automatically - Round-trip validation to ensure data integrity - CLI tools for conversion and validation - Generated protobuf binaries for SDK testing Generated test data: - flags-v1.pb (20KB from 85KB JSON, 76% compression) - bandit-flags-v1.pb (2KB from 11KB JSON, 82% compression) Usage: - yarn convert:protobuf - Convert all UFC files - yarn validate:protobuf - Validate protobuf binaries
🚀 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Removed json-null-value-flag from flags-v1.json - Regenerated flags-v1.pb with updated data - Related test case automatically removed 🚀 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.