Production ready #1
Conversation
|
@codex please review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| if (hotkeyWindow.ShowDialog() == true && hotkeyWindow.HotkeyChanged) | ||
| { | ||
| // Get the captured hotkey | ||
| if (hotkeyWindow.GetCapturedHotkey(out bool useCtrl, out bool useAlt, out bool useWin, out bool useShift, out int virtualKey, out string keyDisplay)) | ||
| { | ||
| // Build modifiers for Win32 API (ignoring Shift as it's handled differently) | ||
| int modifiers = 0; | ||
| if (useCtrl) modifiers |= 0x0002; // MOD_CONTROL | ||
| if (useAlt) modifiers |= 0x0001; // MOD_ALT |
There was a problem hiding this comment.
[P1] Include Shift when registering hotkey
The hotkey configuration dialog captures Shift as a valid modifier (GetCapturedHotkey exposes useShift) and even allows Shift‑only combinations. However, when the new hotkey is registered the Shift flag is ignored—only Ctrl, Alt and Win are added to the modifier bitmask before calling globalHotkey.Register. Any hotkey that the user configures to require Shift is therefore registered without that modifier, meaning pressing the key without Shift (or a Shift‑only selection) still toggles the app and can collide with regular typing. MOD_SHIFT should be included in the registration when useShift is true.
Useful? React with 👍 / 👎.
|
@codex fix comments |
Summary
Testing
Notes
|
|
@codex please try dotnet build again |
Summary
Testing
|
Create dotnet.yml
|
@codex try your changes again and if the build is sucessful commit it |
Summary
Testing
Notes
|
No description provided.