Replace deprecated catch operator with try...catch#164
Merged
bjosv merged 3 commits intoEricsson:mainfrom Apr 22, 2026
Merged
Conversation
Collaborator
|
Good catch(!) but we will probably delete ered_connection. It's deleted in the feature branch single-process-client. If we merge this PR now, it will give us conflicts. Do you want to open this PR against the feature branch instead? Otherwise wait until it's merged. |
Collaborator
Author
I can wait until the feature branch is merged, then I can replace 29.0-rc2 with 29.0.1 depending on the timeframe. |
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
The catch operator is deprecated and OTP 29 will emit compiler warnings for its use. https://www.erlang.org/news/185#compiler-warnings Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
zuiderkwast
approved these changes
Apr 21, 2026
Signed-off-by: User <user@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The catch operator is deprecated and OTP 29 will emit compiler warnings for its use.
Replaced catch with try...catch and start building with OTP 29.0-rc2 in CI.
Reference:
https://www.erlang.org/news/185#compiler-warnings