feat(snapshot-controller): VolumeSnapshotClass component for AWS#41
Merged
danielgines merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
New `components/snapshot-controller/` chart that renders a single VolumeSnapshotClass `ebs-csi-aws` with the `velero.io/csi-volumesnapshot- class: "true"` discovery label. Required for Velero to take CSI snapshots of EBS-backed PVs (without the label, backups skip PV snapshotting entirely → PartiallyFailed phase, observed on cortex prd 2026-05-05). The snapshot-controller deployment + CRDs are installed via the EKS managed addon (provisioned by estabilis-platform v0.46.0 in providers/aws/eks.tf — paired with this chart). Component is consumed by bootstrap/platform-root/templates/ snapshot-controller.yaml in estabilis-platform v0.46.0+ (AWS-only, sync wave 6).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
components/snapshot-controller/chart that ships a single VolumeSnapshotClassebs-csi-awswith thevelero.io/csi-volumesnapshot-class: "true"discovery label.workload-bootstrapChart.yaml + values.yaml + repoVersion tov0.39.10.Why
Velero CSI backups silently skip PV snapshotting when no VolumeSnapshotClass carries the velero discovery label. Observed on cortex prd 2026-05-05: 14 PVs in PartiallyFailed phase after the KMS fix (v0.45.1) unmasked this pre-existing gap.
The snapshot-controller deployment + CRDs come from the EKS managed addon, provisioned in estabilis-platform v0.46.0 (paired PR). This component only ships the VSC.
Pairing
snapshot-controllertolocal.default_addons+bootstrap/platform-root/templates/snapshot-controller.yaml(AWS-only, sync wave 6, consumes this component's values).Test plan
helm templaterenders 1 doc with the AWS overlay; 0 docs withoutyaml.safe_load_allkubectl get volumesnapshotclass ebs-csi-awsreturns the resource with the velero label