Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

Ethran / notable Public

Notifications You must be signed in to change notification settings
Fork 28
Star 187

Code
Issues 30
Pull requests 5
Discussions
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Security
Insights

Improve toolbar code quality #219

Merged

Ethran merged 21 commits intomainEthran/notable:mainfrom

devEthran/notable:devCopy head branch name to clipboard

Mar 9, 2026

Conversation Commits21 (21)Checks Files changed

Merged

Improve toolbar code quality #219
Ethran merged 21 commits intomainfrom
dev

Commits

Commits on Mar 7, 2026

Refactor `Toolbar` and `ToolbarMenu` to use callback functions instead of direct dependency injection of `NavController`, `AppRepository`, and `ExportEngine`.
Ethran
committed
refactor Toolbar to use a decoupled UI state and content function
Ethran
committed
Apply suggestions from code review

Ethran
and
Copilot
authored
Toolbar.kt refactored pen selection logic into isSelected function
Ethran
committed
ToolbarMenu simplified export parameters and added preview
Ethran
committed

Commits on Mar 8, 2026

move Topbar.kt to ui package
Ethran
committed
move PositionedToolbar to its own file
Ethran
committed
create the EditorViewModel.kt
Ethran
committed
Refactor toolbar logic into `EditorViewModel` using a modern MVI-pattern approach.
Ethran
committed
implement reloadFromDb event and rename restartAfterConfChange to reinitSignal
Ethran
committed
Refactor menu and drawing state management to EditorViewModel
Ethran
committed

Commits on Mar 9, 2026

code formating
Ethran
committed
EditorViewModel: refactor handleEraserChange and add stroke selection logic
Ethran
committed
change from log.e to log.d
Ethran
committed
change from log.e to log.d
Ethran
committed
add comments
Ethran
committed
EditorViewModel: calculate and update background page number for PDF backgrounds
Ethran
committed
PageView.kt updated background caching and logging; changed debug color in pageDrawing.kt
Ethran
committed
change log level
Ethran
committed
correct typo
Ethran
committed
move side-effects out of _toolbarState.update in EditorViewModel
Ethran
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.