Fix CSV export truncation + frontend JS null guards#29
Conversation
Export now pages through chat-log query (100/page cap) instead of requesting per_page=10000 that query() silently clamped to 100. Add null guards before two DOM dereferences in click handlers.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughAdds null-safety guards to frontend click handlers, changes admin CSV export to paginate through all chat log results, and updates POT/PO metadata timestamps and source reference line numbers. ChangesFrontend DOM Safety Checks
Backend CSV Export Pagination
i18n PO/POT Metadata Updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Follow-up to #28. Addresses two pre-existing CodeRabbit findings (not rename artifacts).
CSV export silently truncated at 100 rows (Major)
handle_export()requestedper_page => 10000, butEttic_OTC_Chat_Log::query()clampsper_pagewithmin(100, …)to protect the admin list view. Any questions log with >100 rows exported only the most recent 100.Fix: keep the 100-row query cap, but page through results in the export handler until the full filtered set is written.
frontend.js null guards (Minor)
Two click handlers dereferenced DOM lookups that assume sibling/container markup always exists (
card.querySelector,text.classList). If markup drifts they throw and break later interactions. Added null guards.🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Documentation