feat: replace/extend default HTTP headers with custom ones#2
feat: replace/extend default HTTP headers with custom ones#2Endebert wants to merge 1 commit intoEventSource:masterfrom
Conversation
Added a new (optional) argument to the pipe() function that adds the ability to replace the default HTTP headers for the request, or add custom ones. Includes additional test and updated README.md
|
this should be added via the constructor, see my fork at https://github.com/soyuka/ssestream |
|
@soyuka Thanks for the info. Could you please try your luck & create a PR with your changes? Maybe you have more luck than us, though I don't have high hopes. |
|
@Endebert if this project is maintained the maintainers will definitely have a look, if not you should use something that is maintained :). Also you have maf's alternative that is also widely used since longer: https://github.com/mafintosh/event-source-stream/. In my fork I took the liberty of merging a few resouces that I found over the web: |
|
@soyuka Thanks for all the info :) |
Added a new (optional) argument to the
pipe()function that adds the ability to replace the default HTTP headers for the request, or add custom ones.Includes additional test and updated README.md.
This covers the use-case for #1. However, my PR adds this functionality using a new argument, i.e. it's not a breaking change.
In the meantime, my modified version is published as "@tillhub/node-ssestream": https://www.npmjs.com/package/@tillhub/node-ssestream