Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR transitions the classification BDT training from separate models for each telescope multiplicity (2, 3, 4 telescopes) to a single unified model trained on all telescope multiplicities. This architectural change simplifies the model structure and is reflected in the VTS (Variable Telescope System) implementation.
Changes:
- Updated model configuration structure to remove telescope multiplicity nesting level
- Added core position features (Xcore, Ycore) to classification features
- Implemented conditional handling of size-related variables based on analysis type
- Updated documentation to reflect single BDT training approach
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/eventdisplay_ml/scripts/train_xgb_classify.py | Updated docstring to reflect training a single BDT for all telescope multiplicities |
| src/eventdisplay_ml/models.py | Removed telescope multiplicity level from model configuration structure when collecting threshold keys |
| src/eventdisplay_ml/features.py | Added size to telescope features and Xcore/Ycore to classification features; updated comments to clarify size usage |
| src/eventdisplay_ml/data_processing.py | Added analysis_type parameter to flatten_telescope_variables; implemented conditional logic to handle size-related variables differently for classification vs stereo_analysis |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.