fix: await notifyCollabMutation on marks mutation routes#8
Open
tmchow wants to merge 1 commit intoEveryInc:mainfrom
Open
fix: await notifyCollabMutation on marks mutation routes#8tmchow wants to merge 1 commit intoEveryInc:mainfrom
tmchow wants to merge 1 commit intoEveryInc:mainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
All marks mutation routes were calling
notifyCollabMutationwithoutawait:The
editandedit/v2routes already awaited it correctly. The marks routes did not.Impact
notifyCollabMutationbecame unhandled promise rejections instead of propagating to the callerFix
Added
awaitto all 9 unawaited callsites inserver/agent-routes.ts:marks/commentmarks/suggest-replacemarks/suggest-insertmarks/suggest-deletemarks/rejectmarks/replymarks/resolvemarks/unresolveNo logic changes — surgical
awaitadditions only.