MID-9537 Resolve filtered connectorRef for additional connectors#647
Open
kay1313 wants to merge 1 commit into
Open
MID-9537 Resolve filtered connectorRef for additional connectors#647kay1313 wants to merge 1 commit into
kay1313 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes MID-9537: additional connectors failed when their
connectorRefwas specified using a filter instead of a direct OID.The primary resource
connectorRefalready supported filter-based resolution, butConnectorSpec.Additionalstill required an OID directly from the resource definition. This caused resource completion to fail with:Changes
Added filter-based connector reference resolution in
ConnectorManager.Reuses the resolved connector OID for cache lookup and connector instance creation.
Stores the resolved connector OID as transient state in
ConnectorSpec.Does not mutate the resource
connectorRef.Does not create or persist repository deltas for the resolved OID.
Added
ConnectorSpec#getConnectorRef()so both main and additional connector specs can expose their backing reference.Added regression tests for:
connectorRefby filterconnectorRefby filterconnectorRefby direct OIDAdded release notes entry.
Testing
Added/updated CSV provisioning tests in
AbstractCsvTest.The tests verify that filter-based additional connector references are resolved internally, remain invisible in the returned resource object, and are not persisted to the repository.