MID-10905 Add input variable to existence mappings#649
Open
kay1313 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes MID-10905 by exposing the documented
inputvariable in resource activation existence mappings.Existence mappings already used the computed projection legality value as the default source named
legal. However, the documentation says that the same legality value is available asinput. Expressions explicitly referencinginputfailed withNo such property: input.This change keeps
legalas the default source to preserve existing behavior, including<asIs/>, and addsinputas an additional source backed by the same legality IDI.Changes
inputas an additional source inActivationProcessor.evaluateExistenceMapping.legalas the default source for backward compatibility.input == legaland returnsinput.test830ExistenceInputcovering both:Manual verification
Verified manually in GUI using a resource existence mapping script that throws debug output.
On the fixed branch, the existence mapping saw:
input=true,legal=true,assigned=true,focusExists=trueinput=false,legal=false,assigned=false,focusExists=trueOn current master, the same mapping failed with:
Groovy Evaluation Failed: No such property: inputThe master error context contained
legal,assigned, andfocusExists, but notinput.