MID-9879 Add inline type support for collection filters#651
Open
kay1313 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed MID-9879: dashboard widgets with inline object collection filters could not be evaluated when no referenced object collection was used.
Previously, this configuration was accepted:
but the widget failed at runtime with
UndefinedTypeForCollection, becauseCollectionRefSpecificationTypeallowed an inline filter but had no way to specify the object type.This PR adds optional explicit type support to
CollectionRefSpecificationType:Changes
<type>toCollectionRefSpecificationTypeincommon-gui-3.xsd.CollectionProcessorto use the explicit collection type when parsing inline filters.Manual verification
Verified manually in GUI:
UndefinedTypeForCollection/ widget rendered asUnknown.collectionRef-based widget configuration was checked and still works.