fix(cicd): auto-select free port and fix qwen3 FSDP2 attention_type compat#151
Open
fix(cicd): auto-select free port and fix qwen3 FSDP2 attention_type compat#151
Conversation
…ompat - Add find_free_port() in test/train/utils.py so CICD tests no longer hardcode port 8000, avoiding conflicts on shared machines. - Fix AttributeError in qwen3_ops.py where FSDP2-wrapped decoder layers lose the attention_type attribute. Use config.layer_types[i] (new transformers API) with fallback to decoder_layer.attention_type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find_free_port()intest/train/utils.pyso torchrun no longer hardcodes port 8000, avoiding conflicts on shared machines.Qwen3DecoderLayerloses theattention_typeattribute. Now usesconfig.layer_types[i](new transformers 5.x API) with fallback todecoder_layer.attention_typefor older versions.Verified
All CICD tests pass with 2 GPUs:
qwen3_vl: 2/2 passedqwen3: 2/2 passedqwen2_5_vl: 3/3 passed