fix(dataset): join data_folder with video path in Qwen3VL iterable dataset#152
Merged
fix(dataset): join data_folder with video path in Qwen3VL iterable dataset#152
Conversation
…taset load_videos() received data_folder but never joined it with the relative video_path before passing to load_video_qwen_vl_utils(), causing file:// URLs to use bare relative paths that fail to resolve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Qwen3VLIterableDataset.load_videos()receivesdata_folderbut never joins it with the relativevideo_pathbefore passing toload_video_qwen_vl_utils(). This causesfile://URLs to use bare relative paths (e.g.file://academic_source/Charades/028CE.mp4) that fail to resolve.load_videos()inqwen3_vl_iterable_dataset.pyskips theos.path.join(data_folder, video_path)step that the base mixin and the naiveqwen3_vl_dataset.pyboth perform correctly.data_folderjoin at the top ofload_videos(), consistent with every other dataset implementation.