Fix timestamp unit mismatch in TokenBucket and LeakyBucket clean/1#176
Merged
Fix timestamp unit mismatch in TokenBucket and LeakyBucket clean/1#176
Conversation
hit/5 stores timestamps in seconds (System.system_time(:second)), but clean/1 was using ETS.now() which returns milliseconds. This caused all entries to appear stale and get deleted every cleanup cycle, silently resetting rate limits. - Use System.system_time(:second) in clean/1 to match hit/5 - Convert key_older_than from ms to seconds with div/2 - Update tests to set key_older_than: 1000 so entries age out in tests Fixes #174
The Atomic backend's clean/1 had the same bug: hit/5 stores timestamps in seconds for TokenBucket/LeakyBucket, but clean/1 compared using now() which returns milliseconds. Branch clean/1 by algorithm: FixWindow correctly uses milliseconds throughout, while bucket algorithms now use seconds with key_older_than converted from ms to seconds via div/2. Fixes #174
Extract clean_fix_window/1 and clean_bucket/1 to reduce nesting depth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hit/5 stores timestamps in seconds (System.system_time(:second)), but clean/1 was using ETS.now() which returns milliseconds. This caused all entries to appear stale and get deleted every cleanup cycle, silently resetting rate limits.
Fixes #174