Merged
Conversation
Member
VsevolodX
commented
Mar 2, 2026
VsevolodX
commented
- update: calculate hash
- update: test hashing
| "schemaVersion": "2022.8.16" | ||
| }, | ||
| "hash": "b7353f1be53119573f184497442e3202" | ||
| } |
Member
There was a problem hiding this comment.
Nit, but should we get this from standata?
Member
Author
There was a problem hiding this comment.
Maybe, that's what I did for WF. But at least hash must be here in the common folder to compare Py/JS.
tests/py/test_application.py
Outdated
| def test_calculate_hash_matches_fixture(): | ||
| fixture_path = Path(__file__).parent.parent / "fixtures" / "application_hash.json" | ||
| fixture = json.loads(fixture_path.read_text()) | ||
| from mat3ra.standata.applications import ApplicationStandata |
Member
There was a problem hiding this comment.
Why import here?? Should be at the top
timurbazhirov
approved these changes
Mar 3, 2026
pyproject.toml
Outdated
| "mat3ra-code", | ||
| "mat3ra-utils[extra]" | ||
| "mat3ra-utils[extra]", | ||
| "mat3ra-standata" |
Member
There was a problem hiding this comment.
We don't need standata here
Member
Author
There was a problem hiding this comment.
oh, only in tests, right?
|
Coverage after merging feature/SOF-7843 into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.