Merged
Conversation
Member
VsevolodX
commented
Apr 7, 2026
VsevolodX
commented
- update: add generic convergence
- update: add test
| parameter_increment: Any, | ||
| reciprocal_vector_ratios: Optional[List[float]] = None, | ||
| result: str = ENERGY_CONVERGENCE_RESULT, | ||
| param_name: str, |
Member
There was a problem hiding this comment.
param -> parameter everywhere
VsevolodX
commented
Apr 7, 2026
| ) | ||
|
|
||
| @staticmethod | ||
| def _inject_template_variable(unit, param_name: str) -> None: |
Member
Author
There was a problem hiding this comment.
Move to Ade
replace_text(pattern, value)
Comment on lines
+289
to
+293
| numeric = r"[\d.e+\-]+" | ||
| jinja_var = r"\{\{[^}]+\}\}" | ||
| pattern = rf"{param_name}\s*=\s*(?:{numeric}|{jinja_var})" | ||
| replacement = f"{param_name} = {{% raw %}}{{{{ {param_name} }}}}{{% endraw %}}" | ||
| for input_item in unit.input: |
Member
There was a problem hiding this comment.
This function should be split in two - one that changes Jinja template text, the other one that changes input items for unit with new text
|
|
||
|
|
||
| # TODO: use from ESSE when epic/SOF-7756 merged | ||
| class ExecutionUnitInputItem(InMemoryEntitySnakeCase): |
| "mat3ra-esse", | ||
| "mat3ra-mode", | ||
| "mat3ra-ade", | ||
| "mat3ra-ade @ git+https://github.com/Exabyte-io/ade.git@9ef73f59d2099cda4426011ed1f31891ee19b68c", |
Member
Author
|
moved onto feature/SOF-7878-1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.