fix: grant camera permission based on origin#36
Merged
Conversation
633kh4ck
suggested changes
Feb 20, 2025
android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java
Outdated
Show resolved
Hide resolved
633kh4ck
changed the title
633kh4ck
reviewed
Feb 20, 2025
| return; | ||
| NSString *originString = [NSString stringWithFormat:@"%@://%@", origin.protocol, origin.host]; | ||
|
|
||
| if (origin.port > 0 && (([origin.protocol isEqualToString:@"http"] && origin.port != 80) || ([origin.protocol isEqualToString:@"https"] && origin.port != 443))) { |
There was a problem hiding this comment.
TODO: test if protocol is normalized, i.e., ifHttP is treated as http, just in case
Author
There was a problem hiding this comment.
Does this actually matter? If HttP is treated as http, the constructed originString won’t match the check below and will be denied.
// Example:
// originString: 'HttPs://camerasite.com'
// cameraPermissionOriginWhitelist: ['https://camerasite.com']
if ([self.cameraPermissionOriginWhitelist containsObject:originString]) { // wouldn't match hence deniedI think it’s fine for this case to result in denial, so there’s no need to normalize the protocol.
|
post-merge nACK For fixed in #46 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing some improve feedback from this PR