You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This adds test cases to demonstrate #138
I am not really sure where to start fixing this. It is important to note that the case using draft 2019-09 passes, while it fails when using draft 07.
If there is any direction you can point me to, I will try to fix this.
But in pre-2019 mode, combining $ref and any other keywords ignores everything except $ref per spec, this is why it complains on unprocessed type.
A simple fix would be to replace { type: 'string', ...names } with { type: 'string', allOf: [names]} on the line above, but I'll recheck if there is a cleaner solution.
As a work-around, { allOf: [{ $ref: ... }] } should work with all versions.
This is not the correct location for this test, as test/extra-tests/ref.383.json is manually synced with json-schema-org/JSON-Schema-Test-Suite#383 (as are other prs in that dir), but I'll fix (and document) that post-merge. It wasn't documented.
Upd: done in e582f39...4faa854.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds test cases to demonstrate #138
I am not really sure where to start fixing this. It is important to note that the case using draft 2019-09 passes, while it fails when using draft 07.
If there is any direction you can point me to, I will try to fix this.