fix: standard scaling do not replace 0 variance with epsilon#53
Open
mandrecki wants to merge 2 commits into
Open
fix: standard scaling do not replace 0 variance with epsilon#53mandrecki wants to merge 2 commits into
mandrecki wants to merge 2 commits into
Conversation
…put 0 - same as in spark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On tensorflow side, in standard scaler zero variance was replaced by tiny float. This was not matching spark behaviour where 0 is output in such case. Aligned tensorflow layers to spark. Added tests for zero variance condition.
Conditional standard scaler was actually working but I simplified the code.