-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Receipt thumbnail should show the top of the receipt #35041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
feb57ae
fix: 34120
dukenv0307 0eeedc9
fix: redundant
dukenv0307 8e3d0fc
Merge branch 'main' into fix/34120
dukenv0307 5e5adb8
fix lint
dukenv0307 2e260e6
fix lint
dukenv0307 7fce375
Merge branch 'main' into fix/34120
dukenv0307 6939350
fix crash bug
dukenv0307 7c9c40f
fix lint
dukenv0307 68ffee4
Merge branch 'main' into fix/34120
dukenv0307 a153e8a
fix lint
dukenv0307 0103a6e
Merge branch 'main' into fix/34120
dukenv0307 2125302
fix the case wide image
dukenv0307 00ccc9b
add comment prop
dukenv0307 bac3d4d
Merge branch 'main' into fix/34120
dukenv0307 c761e1c
merge main
dukenv0307 13acc33
resolve conflict
dukenv0307 d09ee20
centralize logic
dukenv0307 354c9bc
Merge branch 'main' into fix/34120
dukenv0307 7cf8fd8
fix lint
dukenv0307 9b30a3d
merge main and optimize logic
dukenv0307 86190f6
revert hard code
dukenv0307 fd26a31
resolve conflict
dukenv0307 ba5051d
merge main
dukenv0307 3d63a64
merge main
dukenv0307 54d0bb9
fix lint
dukenv0307 5b1c883
replace objectPositionTop with objectPosition
dukenv0307 115ec92
update objectPosition prop
dukenv0307 1562a88
fix order import
dukenv0307 fcdcb65
Merge branch 'main' into fix/34120
dukenv0307 4839282
Merge branch 'main' into fix/34120
dukenv0307 3e61229
fix offline case
dukenv0307 aa3247f
merge main
dukenv0307 e4532de
resolve conflict
dukenv0307 0b8f6d2
Merge branch 'main' into fix/34120
dukenv0307 681aae8
Merge branch 'main' into fix/34120
dukenv0307 2ab8b38
Merge branch 'main' into fix/34120
dukenv0307 67a43d7
Merge branch 'main' into fix/34120
dukenv0307 7a748f5
Merge branch 'main' into fix/34120
dukenv0307 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you quickly comment on the changes related to the auth token? (this line, but also some other lines in the whole PR diff)
Does adjusting the thumbnail positioning have some relation with auth tokens? I'm trying to ensure we got conflict resolution right.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cubuspl42 As I mentioned here #35041 (comment), we can use the thumbnail to render the receipt when it's a local file to fix the issue here #35041 (comment). So I want to control
isAuthTokenRequiredofThumnailImageviaisAuthTokenRequiredprop.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is also the reason for the change in
ReportActionItemImageThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I forgot. This is definitely a sign we should wrap this up.