Skip to content

Fix memory leak with Animated API #68834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 2 commits into from
Aug 20, 2025
Merged

Fix memory leak with Animated API #68834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9af8207
Fix memory leak with Animated API
staszekscp Aug 20, 2025
e81d352
Add PR number to details.md file
staszekscp Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions patches/react-native-web/details.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,14 @@
- Upstream PR/issue: The patch isn't something we can apply to upstream because we are specifically allowing custom props used by Fullstory to be forwarded to their respective DOM elements.
- E/App issue: As explained above the current solution can't be applied to upstream because it's tailored to Fullstory needs.
- PR introducing patch: https://github.com/Expensify/App/pull/67552

### [react-native-web+0.20.0+011+fix-memory-leak.patch](react-native-web+0.20.0+011+fix-memory-leak.patch)
- Reason:

```
Fixes memory leak on web caused by Animated API used in @react-navigation package
```

- Upstream PR/issue: https://github.com/necolas/react-native-web/pull/2800
- E/App issue: https://github.com/Expensify/App/issues/65820
- PR introducing patch: https://github.com/Expensify/App/pull/68834
12 changes: 12 additions & 0 deletions patches/react-native-web/react-native-web+0.20.0+011+fix-memory-leak.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
diff --git a/node_modules/react-native-web/dist/vendor/react-native/Animated/nodes/AnimatedProps.js b/node_modules/react-native-web/dist/vendor/react-native/Animated/nodes/AnimatedProps.js
index 9ba3336..2d67005 100644
--- a/node_modules/react-native-web/dist/vendor/react-native/Animated/nodes/AnimatedProps.js
+++ b/node_modules/react-native-web/dist/vendor/react-native/Animated/nodes/AnimatedProps.js
@@ -68,6 +68,7 @@ class AnimatedProps extends AnimatedNode {
if (this.__isNative && this._animatedView) {
this.__disconnectAnimatedView();
}
+ this._animatedView = null
for (var key in this._props) {
var value = this._props[key];
if (value instanceof AnimatedNode) {
Loading