fix: apple login page overlaps device status bar#74775
fix: apple login page overlaps device status bar#74775Julesssss merged 13 commits intoExpensify:mainfrom
Conversation
|
|
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
For IOS, I am having build issues, will complete it soon. Thanks |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppbefore: android-before.movafter: android-after.movAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
There was a problem hiding this comment.
Android works well.
I think we need help from internal engineer for testing iOS in adhoc build.
cc: @Julesssss
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
Julesssss
left a comment
There was a problem hiding this comment.
Will test on iOS AdHoc
This comment has been minimized.
This comment has been minimized.
|
Still same ^, I am still debugging/fixing the bug, in the meanwhile, @Julesssss Could you please try another adhoc build and try again if the issue still occurs?. Many thanks cc: @situchan |
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
@Julesssss Any updates? |
|
I forgot about this, my bad. I just retested but am getting the force upload modal due to the old app version. Would you mind re-merging main and I'll try again. |
Done |
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Julesssss
left a comment
There was a problem hiding this comment.
A couple of build errors: https://github.com/Expensify/App/actions/runs/19867933558/job/56935701287
Fixed ☑️ |
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Hmm yeah same issue. BUT I just checked another build and this seems to happen on all AdHoc builds 😕 Okay lets get this tested properly on a staging build. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Thanks |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.2.72-0 🚀
|
Apple sign in works fine on staging. UI looks different in my case (because I am signed into Apple on my device?) but there is no overlap. |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.2.72-2 🚀
|




Explanation of Change
fullScreen: falseto the android configurationFixed Issues
$ #64116
PROPOSAL: #64116 (comment)
Tests
Offline tests
This tests requires internet connection
QA Steps
QA and InternalQA test steps Both Android and iOS
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-11-15.at.14.20.00.mov
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop