Global nav bar POC and Spend/Workspace layout refinements#91955
Draft
shawnborton wants to merge 16 commits into
Draft
Global nav bar POC and Spend/Workspace layout refinements#91955shawnborton wants to merge 16 commits into
shawnborton wants to merge 16 commits into
Conversation
…radius, Cmd+K badge
…LHN header refinements
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 162f0d6f43c..5e142a82a02 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -7303,8 +7303,8 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
syncing: 'Mitarbeitende werden synchronisiert',
},
emptyDomain: {
- title: 'Stärken Sie Ihre Sicherheit mit Domains',
- subtitle: 'Verlangen Sie, dass Mitglieder in Ihrer Domain sich per Single Sign-On anmelden, schränken Sie das Erstellen von Arbeitsbereichen ein und mehr.',
+ title: 'Erhöhen Sie Ihre Sicherheit mit Domains',
+ subtitle: 'Verlangen Sie von Mitgliedern Ihrer Domain die Anmeldung über Single Sign-On, beschränken Sie das Erstellen von Arbeitsbereichen und mehr.',
},
},
getAssistancePage: {
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 96ff1240ee0..211db957185 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -7097,7 +7097,7 @@ ${amount} para ${merchant} - ${date}`,
},
emptyDomain: {
title: 'Mejora tu seguridad con dominios',
- subtitle: 'Exige que los miembros de tu dominio inicien sesión mediante inicio de sesión único, restrinjan la creación de espacios de trabajo y más.',
+ subtitle: 'Obliga a las personas de tu dominio a iniciar sesión mediante inicio de sesión único, restringe la creación de espacios de trabajo y mucho más.',
},
},
getAssistancePage: {
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index b4d4ee53075..52445a55434 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -2808,9 +2808,9 @@ ${amount} pour ${merchant} - ${date}`,
title: 'Modifier l’agent',
agentName: 'Nom de l’agent',
instructions: 'Écrire des instructions personnalisées',
- chatWithAgent: 'Discuter avec l\u2019agent',
+ chatWithAgent: 'Discuter avec l’agent',
copilotIntoAccount: 'Copilote dans le compte',
- deleteAgent: 'Supprimer l\u2019agent',
+ deleteAgent: 'Supprimer l’agent',
deleteAgentTitle: 'Supprimer l’agent ?',
deleteAgentMessage: 'Voulez-vous vraiment supprimer cet agent ? Cette action est irréversible.',
},
@@ -4413,7 +4413,7 @@ ${amount} pour ${merchant} - ${date}`,
travelInvoicingPayableAccount: 'Compte fournisseur déplacements',
hr: 'RH',
rooms: 'Salons',
- findDomain: 'Trouver un domaine',
+ findDomain: 'Rechercher un domaine',
cardAdminAlternateText: 'Gérer les cartes de l’espace de travail.',
peopleAdminAlternateText: 'Gérez les membres et les workflows d’approbation.',
paymentsAdminAlternateText: 'Gérer les paiements de workflow.',
@@ -7334,7 +7334,7 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
},
emptyDomain: {
title: 'Renforcez votre sécurité avec des domaines',
- subtitle: 'Obligez les membres de votre domaine à se connecter via l’authentification unique, restreignez la création d’espaces de travail, et plus encore.',
+ subtitle: 'Exiger que les membres de votre domaine se connectent via l’authentification unique, restreindre la création d’espaces de travail, et plus encore.',
},
},
getAssistancePage: {
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 19d77aafcfa..86efad83c04 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -2796,8 +2796,8 @@ ${amount} per ${merchant} - ${date}`,
title: 'Modifica agente',
agentName: 'Nome agente',
instructions: 'Scrivi istruzioni personalizzate',
- chatWithAgent: 'Chatta con l\u2019agente',
- copilotIntoAccount: 'Copilot nell\u2019account',
+ chatWithAgent: 'Chatta con l’agente',
+ copilotIntoAccount: 'Copilot nell’account',
deleteAgent: 'Elimina agente',
deleteAgentTitle: 'Eliminare agente?',
deleteAgentMessage: 'Sei sicuro di voler eliminare questo agente? Questa azione non può essere annullata.',
@@ -7288,8 +7288,8 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
syncing: 'Sincronizzazione dipendenti',
},
emptyDomain: {
- title: 'Migliora la tua sicurezza con i domini',
- subtitle: 'Richiedi ai membri del tuo dominio di accedere tramite accesso Single Sign-On, limita la creazione di space di lavoro e altro ancora.',
+ title: 'Aumenta la tua sicurezza con i domini',
+ subtitle: 'Richiedi ai membri del tuo dominio di accedere tramite single sign-on, limita la creazione di workspace e altro ancora.',
},
},
getAssistancePage: {
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 81d16745f98..6a90e4e399d 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -7255,7 +7255,7 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
syncing: 'Synchronizowanie pracowników',
},
emptyDomain: {
- title: 'Zwiększ swoje bezpieczeństwo dzięki domenom',
+ title: 'Zwiększ swoje bezpieczeństwo za pomocą domen',
subtitle: 'Wymagaj od członków swojej domeny logowania jednokrotnym logowaniem (SSO), ograniczaj tworzenie przestrzeni roboczych i nie tylko.',
},
},
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index fcf4c886028..9fdc78bef93 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -7261,10 +7261,7 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
syncingModalDescription: 'A primeira conexão pode levar algum tempo. Você será notificado sobre quaisquer erros.',
syncing: 'Sincronizando funcionários',
},
- emptyDomain: {
- title: 'Aumente sua segurança com domínios',
- subtitle: 'Exija que os membros do seu domínio façam login via logon único, restrinja a criação de workspaces e muito mais.',
- },
+ emptyDomain: {title: 'Aumente sua segurança com domínios', subtitle: 'Exija que membros do seu domínio entrem via logon único, restrinja a criação de workspaces e muito mais.'},
},
getAssistancePage: {
title: 'Obter ajuda',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 6edd51e1d39..8d0c564cf3d 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -7072,7 +7072,7 @@ ${reportName}
syncingModalDescription: '首次连接可能需要一些时间。若发生任何错误，我们会通知你。',
syncing: '正在同步员工',
},
- emptyDomain: {title: '通过域名提升安全性', subtitle: '要求您域中的成员通过单点登录登录、限制工作区创建等。'},
+ emptyDomain: {title: '通过域名增强安全性', subtitle: '要求您域中的成员通过单点登录登录、限制工作区创建等。'},
},
getAssistancePage: {
title: '获取帮助',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Contributor
|
🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Contributor
|
🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR is a design/UX POC bundling several layout and styling refinements. Highlights:
topBarLabel(Expensify New Kansas) header font with truncation. Removes illustrations from those headers.cardMaxWidth: 760/contentMaxWidth: 1140to Account, Workspace, and Domain pages so content is centered on wide screens with 20px padding.appBG, no border radius, and 20px horizontal padding.textSupportingwhile keeping the danger-colored icon.shouldOffsetForGlobalNavBar: New opt-in prop onScreenWrapperContainerto subtract the global nav bar height from max/min height — applied across Account and Workspace pages.Fixed Issues
$
PROPOSAL:
Tests
cardMaxWidth, and pages don't get cut off at the bottom.Offline tests
Same as tests — verify no regressions in the layouts when offline.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screenshots/Videosundefined