add Certinia advanced settings page with dynamic routing#91967
Open
ChavdaSachin wants to merge 2 commits into
Open
add Certinia advanced settings page with dynamic routing#91967ChavdaSachin wants to merge 2 commits into
ChavdaSachin wants to merge 2 commits into
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 7e70bae4845..041f388efdd 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -4861,8 +4861,9 @@ ${amount} für ${merchant} – ${date}`,
},
certinia: {
title: 'Certinia',
- autoSyncDescription: 'Expensify will automatically sync with Certinia every day.',
- syncReimbursedReportsDescription: 'With this option enabled, anytime a Payable Invoice is paid in FFA, the related Expensify report will be automatically marked as reimbursed.',
+ autoSyncDescription: 'Expensify wird jeden Tag automatisch mit Certinia synchronisiert.',
+ syncReimbursedReportsDescription:
+ 'Wenn diese Option aktiviert ist, wird jedes Mal, wenn eine zu zahlende Rechnung in FFA bezahlt wird, der zugehörige Expensify-Bericht automatisch als erstattet markiert.',
prerequisites: {
title: 'Bevor Sie die Verbindung herstellen',
installBundle: 'Für FFA-Verbindungen',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 79e7f4219d7..faef6c40b48 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -4748,8 +4748,9 @@ ${amount} para ${merchant} - ${date}`,
},
certinia: {
title: 'Certinia',
- autoSyncDescription: 'Expensify will automatically sync with Certinia every day.',
- syncReimbursedReportsDescription: 'With this option enabled, anytime a Payable Invoice is paid in FFA, the related Expensify report will be automatically marked as reimbursed.',
+ autoSyncDescription: 'Expensify se sincronizará automáticamente con Certinia cada día.',
+ syncReimbursedReportsDescription:
+ 'Con esta opción habilitada, cada vez que se pague una factura por pagar en FFA, el informe de Expensify relacionado se marcará automáticamente como reembolsado.',
prerequisites: {
title: 'Antes de conectarte',
installBundle: 'Para conexiones FFA',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index e78508b8bae..4d4de366ccc 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -2808,9 +2808,9 @@ ${amount} pour ${merchant} - ${date}`,
title: 'Modifier l’agent',
agentName: 'Nom de l’agent',
instructions: 'Écrire des instructions personnalisées',
- chatWithAgent: 'Discuter avec l\u2019agent',
+ chatWithAgent: 'Discuter avec l’agent',
copilotIntoAccount: 'Copilote dans le compte',
- deleteAgent: 'Supprimer l\u2019agent',
+ deleteAgent: 'Supprimer l’agent',
deleteAgentTitle: 'Supprimer l’agent ?',
deleteAgentMessage: 'Voulez-vous vraiment supprimer cet agent ? Cette action est irréversible.',
},
@@ -4873,8 +4873,9 @@ ${amount} pour ${merchant} - ${date}`,
},
certinia: {
title: 'Certinia',
- autoSyncDescription: 'Expensify will automatically sync with Certinia every day.',
- syncReimbursedReportsDescription: 'With this option enabled, anytime a Payable Invoice is paid in FFA, the related Expensify report will be automatically marked as reimbursed.',
+ autoSyncDescription: 'Expensify se synchronisera automatiquement avec Certinia chaque jour.',
+ syncReimbursedReportsDescription:
+ 'Lorsque cette option est activée, chaque fois qu’une facture à payer est réglée dans FFA, la note de frais Expensify associée est automatiquement marquée comme remboursée.',
prerequisites: {
title: 'Avant de vous connecter',
installBundle: 'Pour les connexions FFA',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 622754a60ce..462171e7bb1 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -2796,8 +2796,8 @@ ${amount} per ${merchant} - ${date}`,
title: 'Modifica agente',
agentName: 'Nome agente',
instructions: 'Scrivi istruzioni personalizzate',
- chatWithAgent: 'Chatta con l\u2019agente',
- copilotIntoAccount: 'Copilot nell\u2019account',
+ chatWithAgent: 'Chatta con l’agente',
+ copilotIntoAccount: 'Copilot nell’account',
deleteAgent: 'Elimina agente',
deleteAgentTitle: 'Eliminare agente?',
deleteAgentMessage: 'Sei sicuro di voler eliminare questo agente? Questa azione non può essere annullata.',
@@ -4846,8 +4846,9 @@ ${amount} per ${merchant} - ${date}`,
},
certinia: {
title: 'Certinia',
- autoSyncDescription: 'Expensify will automatically sync with Certinia every day.',
- syncReimbursedReportsDescription: 'With this option enabled, anytime a Payable Invoice is paid in FFA, the related Expensify report will be automatically marked as reimbursed.',
+ autoSyncDescription: 'Expensify si sincronizzerà automaticamente con Certinia ogni giorno.',
+ syncReimbursedReportsDescription:
+ 'Con questa opzione abilitata, ogni volta che una fattura da pagare viene saldata in FFA, il relativo report Expensify sarà automaticamente contrassegnato come rimborsato.',
prerequisites: {
title: 'Prima di connetterti',
installBundle: 'Per connessioni FFA',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 39609fab2f8..a6cba6cfa00 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -4803,8 +4803,8 @@ ${integrationName === CONST.ONBOARDING_ACCOUNTING_MAPPING.other ? 'あなたの'
},
certinia: {
title: 'Certinia',
- autoSyncDescription: 'Expensify will automatically sync with Certinia every day.',
- syncReimbursedReportsDescription: 'With this option enabled, anytime a Payable Invoice is paid in FFA, the related Expensify report will be automatically marked as reimbursed.',
+ autoSyncDescription: 'Expensify は毎日自動的に Certinia と同期します。',
+ syncReimbursedReportsDescription: 'このオプションを有効にすると、FFA で買掛請求書が支払われるたびに、関連する Expensify レポートが自動的に精算済みとしてマークされます。',
prerequisites: {
title: '接続する前に',
installBundle: 'FFA 接続用',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 6fa5c2e0da4..ba16fa33549 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -4837,8 +4837,9 @@ ${amount} voor ${merchant} - ${date}`,
},
certinia: {
title: 'Certinia',
- autoSyncDescription: 'Expensify will automatically sync with Certinia every day.',
- syncReimbursedReportsDescription: 'With this option enabled, anytime a Payable Invoice is paid in FFA, the related Expensify report will be automatically marked as reimbursed.',
+ autoSyncDescription: 'Expensify wordt elke dag automatisch met Certinia gesynchroniseerd.',
+ syncReimbursedReportsDescription:
+ 'Als deze optie is ingeschakeld, wordt elke keer dat een te betalen factuur in FFA wordt betaald, het bijbehorende Expensify-rapport automatisch als terugbetaald gemarkeerd.',
prerequisites: {
title: 'Voordat je verbinding maakt',
installBundle: 'Voor FFA-verbindingen',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 2a442760d65..270fcde640c 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -4829,8 +4829,9 @@ ${amount} dla ${merchant} - ${date}`,
},
certinia: {
title: 'Certinia',
- autoSyncDescription: 'Expensify will automatically sync with Certinia every day.',
- syncReimbursedReportsDescription: 'With this option enabled, anytime a Payable Invoice is paid in FFA, the related Expensify report will be automatically marked as reimbursed.',
+ autoSyncDescription: 'Expensify będzie automatycznie synchronizować się z Certinia każdego dnia.',
+ syncReimbursedReportsDescription:
+ 'Gdy ta opcja jest włączona, za każdym razem gdy Należna faktura zostanie opłacona w FFA, powiązany raport Expensify zostanie automatycznie oznaczony jako zwrócony.',
prerequisites: {
title: 'Zanim się połączysz',
installBundle: 'Dla połączeń FFA',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 97d3f1785c2..6b9d3827c28 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -4832,8 +4832,9 @@ ${amount} para ${merchant} - ${date}`,
},
certinia: {
title: 'Certinia',
- autoSyncDescription: 'Expensify will automatically sync with Certinia every day.',
- syncReimbursedReportsDescription: 'With this option enabled, anytime a Payable Invoice is paid in FFA, the related Expensify report will be automatically marked as reimbursed.',
+ autoSyncDescription: 'O Expensify vai sincronizar automaticamente com a Certinia todos os dias.',
+ syncReimbursedReportsDescription:
+ 'Com essa opção ativada, sempre que uma Fatura a Pagar for paga no FFA, o relatório correspondente no Expensify será marcado automaticamente como reembolsado.',
prerequisites: {
title: 'Antes de conectar',
installBundle: 'Para conexões FFA',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index becb9ddadde..392c425971c 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -4715,8 +4715,8 @@ ${amount}，商户：${merchant} - 日期：${date}`,
},
certinia: {
title: 'Certinia',
- autoSyncDescription: 'Expensify will automatically sync with Certinia every day.',
- syncReimbursedReportsDescription: 'With this option enabled, anytime a Payable Invoice is paid in FFA, the related Expensify report will be automatically marked as reimbursed.',
+ autoSyncDescription: 'Expensify 将每天自动与 Certinia 同步。',
+ syncReimbursedReportsDescription: '启用此选项后，每当在 FFA 中支付应付发票时，关联的 Expensify 报告将自动标记为已报销。',
prerequisites: {
title: '在你连接之前',
installBundle: '用于 FFA 连接',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
melvin-bot
Bot
requested review from
flaviadefaria and
thelullabyy
and removed request for
a team
|
@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5220cd8cf5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #89436
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Prerequisites: have a workspace connected to Certinia
Advancedrow.Advancedpage again.Auto syncandSync rembursed reports.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-05-28.at.7.18.24.PM.mov