[WIP] Add collapsible Spend sidebar#91974
Draft
KJ21-ENG wants to merge 2 commits into
Draft
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Adds the desktop Spend sidebar collapse/expand behavior behind the Spend search page. The sidebar now starts expanded, can be collapsed to a 76px icon rail, temporarily peeks open on hover over the collapsed rail, keeps section accordions available when expanded, and shifts the main Spend content only for the persisted expanded/collapsed state.
Fixed Issues
$ #91553
PROPOSAL: #91553 (comment)
Tests
Offline tests
N/A. This is a desktop layout-only change for the Spend sidebar and does not add or change network-dependent behavior.
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A - desktop-only Spend sidebar behavior.
Android: mWeb Chrome
N/A - desktop-only Spend sidebar behavior.
iOS: Native
N/A - desktop-only Spend sidebar behavior.
iOS: mWeb Safari
N/A - desktop-only Spend sidebar behavior.
MacOS: Chrome / Safari
Pending: upload screen recording here.