Skip to content

Vendor matching CC - R2: App (Sage Intacct extension)#91976

Draft
Beamanator wants to merge 2 commits into
beaman-vendor-matching-r1-app-phase-3from
beaman-vendor-matching-r2-app
Draft

Vendor matching CC - R2: App (Sage Intacct extension)#91976
Beamanator wants to merge 2 commits into
beaman-vendor-matching-r1-app-phase-3from
beaman-vendor-matching-r2-app

Conversation

@Beamanator
Copy link
Copy Markdown
Contributor

@Beamanator Beamanator commented May 28, 2026

Explanation of Change

App side of R2 (Sage Intacct) for vendor matching CC: extends the R1 (QBO) vendor feature gate + helpers to also cover Sage Intacct workspaces with non-reimbursable export = Credit Card Charge.

Three things:

  1. hasVendorFeature(policy, beta) now matches Intacct too. Returns true if either:
    • QBO is connected with non-reimbursable export = Credit Card or Debit Card (R1, unchanged), OR
    • Sage Intacct is connected with export.nonReimbursable = CREDIT_CARD_CHARGE (R2, new).
  2. getQBOVendors → getMatchingVendors and getQBOVendorByID → getMatchingVendorByID. Same callers, integration-aware return — prefers QBO vendors when QBO is connected, falls back to Intacct vendors (normalized from SageIntacctDataElementWithValue to the Vendor shape consumers expect by dropping the redundant value field and zeroing currency/email).
  3. All call sites updated — Phase 1's ViolationsUtils.getViolationsOnyxData inactive-vendor check, Phase 2's QBO Default vendor row, Phase 3's IOURequestStepVendor RHP selector + MoneyRequestView Vendor row + transaction-vendor name resolution.

The Intacct workspace already has its own Default Vendor flow (SageIntacctNonReimbursableExpensesPage), so this PR adds no new Intacct UI — the existing flow keeps working as-is. The R2 PHP fuzzy-matcher extension + R2 Java QBO-vs-Intacct exporter changes are separate tracks per the R2 tracking issue.

What's NOT in this PR

  • PHP fuzzy-matcher extension (separate Web-Expensify PR, see R2 tracking issue)
  • Java IntacctReportExporterRunnable.java change (deferred to GA per the same wait-for-clean-cutover decision as R1's Java track)
  • Workspace Vendors tab — deferred from the R1 scope; still applies here

Cross-PR dependencies

  • App Phase 3 PR (draft) — this branch is stacked on Phase 3, so the R2 diff only shows over-and-above Phase 3.
  • App Phase 2 PR (draft) — transitive dependency through Phase 3 stacking.
  • App Phase 1 PR (merged) — provides the getQBOVendors / getQBOVendorByID helpers that R2 generalizes.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/638609

PROPOSAL: N/A (internal feature, no external proposal)

Tests

Prerequisite: a workspace with the vendorMatching beta enabled, Sage Intacct connected, and non-reimbursable export = Credit Card Charge.

  1. Open a non-reimbursable expense on an Intacct + CC-Charge workspace.
  2. Verify the Vendor row appears on the expense detail view (mirrors R1 QBO behaviour, gated by hasVendorFeature).
  3. Tap the Vendor row. Verify the IOURequestStepVendor RHP opens with the Intacct vendor list (sourced from policy.connections.intacct.data.vendors, normalized to {id, name}).
  4. Pick a vendor. Verify the row title updates and the value persists.
  5. With Intacct export type flipped to Vendor Bill, verify the Vendor row is hidden.
  6. With Intacct disconnected (or only QBO+VB connected), verify the Vendor row is hidden.

Unit tests: the existing Vendor matching helpers describe in tests/unit/PolicyUtilsTest.ts is extended to cover Intacct across all three helpers — 6 new Intacct-specific cases (CC Charge true, beta-off false, Vendor Bill false; both vendor-list and vendor-by-id helpers verify normalized shape).

  • Verify that no errors appear in the JS console

Offline tests

Same as Tests, executed with the network disabled after step 1. The Intacct selector RHP behaves identically to the QBO selector for offline state (uses the same OfflineWithFeedback + Phase 1 optimistic-data path).

QA Steps

Same as Tests, but on staging with the vendorMatching beta enabled. Internal QA only — feature is gated by beta opt-in and only meaningful on workspaces with Intacct + CC Charge export.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

No new UI in this PR — the existing Vendor row, IOURequestStepVendor RHP, and Default vendor flows from R1 + Phase 2/3 are now reachable for Intacct workspaces; visual is identical to QBO. Will add Intacct-specific screenshots once a real Intacct + CC Charge workspace can be set up alongside the PHP-side fuzzy matcher extension.

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Beamanator added 2 commits May 28, 2026 08:07
@Beamanator
Add CC/DC default vendor row in QBO export settings (Phase 2)
834eed7 
Mirrors the existing Vendor Bill default vendor flow, gated by the
`vendorMatching` beta + QBO Credit/Debit-card export config so the
row only appears for workspaces where the Phase 1 fuzzy matcher can
actually use it. Uses the `updateQuickbooksOnlineNonReimbursableCreditCardDefaultVendor`
action shipped in Phase 1 (#91235).
@Beamanator
R2: Generalize vendor matching helpers to support Sage Intacct
82a69b0 
Extends hasVendorFeature to also return true for Sage Intacct
workspaces with non-reimbursable export = Credit Card Charge.
Renames getQBOVendors / getQBOVendorByID to getMatchingVendors /
getMatchingVendorByID and routes them to whichever supported
integration (QBO or Intacct) is active, normalizing Intacct's
SageIntacctDataElementWithValue to the Vendor shape consumers expect.

Mirrors the R2 PHP fuzzy-matcher extension on the App side so the
Vendor row, IOURequestStepVendor RHP, and inactiveVendor violation
all work for Intacct workspaces. Extends PolicyUtilsTest's Vendor
matching helpers describe block with Intacct branches across all
three helpers (hasVendorFeature, getMatchingVendors,
getMatchingVendorByID).
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026 •
edited by github-actions Bot
Loading

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/SCREENS.ts 100.00% <ø> (ø)
...c/components/ReportActionItem/MoneyRequestView.tsx 75.26% <100.00%> (ø)
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts 100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts 76.92% <ø> (ø)
src/libs/PolicyUtils.ts 71.81% <100.00%> (+0.23%) ⬆️
src/libs/Violations/ViolationsUtils.ts 77.65% <100.00%> (ø)
src/libs/actions/IOU/UpdateMoneyRequest.ts 80.96% <ø> (ø)
...gation/AppNavigator/ModalStackNavigators/index.tsx 6.93% <0.00%> (-0.01%) ⬇️
...rc/pages/iou/request/step/IOURequestStepVendor.tsx 0.00% <0.00%> (ø)
src/ROUTES.ts 18.07% <0.00%> (-0.07%) ⬇️
... and 2 more
... and 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Beamanator Beamanator

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Beamanator