Skip to content

migrate InputFocus/index.website.ts to transitionTracker #91984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
collectioneur wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −5
Draft

migrate InputFocus/index.website.ts to transitionTracker #91984

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/libs/actions/InputFocus/index.web.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// eslint-disable-next-line no-restricted-imports
import {InteractionManager} from 'react-native';
import Onyx from 'react-native-onyx';
import * as Browser from '@libs/Browser';
import TransitionTracker from '@libs/Navigation/TransitionTracker';

Check failure on line 3 in src/libs/actions/InputFocus/index.web.ts

View workflow job for this annotation

GitHub Actions / ESLint check 

'@libs/Navigation/TransitionTracker' import is restricted from being used by a pattern. TransitionTracker is an internal primitive. Please use higher-level APIs (Navigation with 'afterTransition'/'waitForTransition', KeyboardUtils, useConfirmModal). See contributingGuides/INTERACTION_MANAGER.md

Check failure on line 3 in src/libs/actions/InputFocus/index.web.ts

View workflow job for this annotation

GitHub Actions / ESLint check 

'@libs/Navigation/TransitionTracker' import is restricted from being used by a pattern. TransitionTracker is an internal primitive. Please use higher-level APIs (Navigation with 'afterTransition'/'waitForTransition', KeyboardUtils, useConfirmModal). See contributingGuides/INTERACTION_MANAGER.md
import ReportActionComposeFocusManager from '@libs/ReportActionComposeFocusManager';
import ONYXKEYS from '@src/ONYXKEYS';
import type {Modal} from '@src/types/onyx';
Expand All @@ -21,9 +20,11 @@
}
if (!isFocused && !onyxFocused && !modal.willAlertModalBecomeVisible && !modal.isVisible && refSave) {
if (!ReportActionComposeFocusManager.isFocused()) {
// Focusing will fail when it is called immediately after closing modal so we call it after interaction.
InteractionManager.runAfterInteractions(() => {
refSave?.focus();
TransitionTracker.runAfterTransitions({
callback: () => {
refSave?.focus();
},
waitForUpcomingTransition: true,
});
} else {
refSave = undefined;
Expand Down
Loading