[Home Page] Fix: Your spend section does not update after updating expense offline by adamgrzybowski · Pull Request #93081 · Expensify/App

adamgrzybowski · 2026-06-09T14:47:36Z

Explanation of Change

The Home "Your spend" totals (Awaiting approval and Repaid in the last 30 days) come from cached search snapshots the server only refreshes while online, so most offline money-request actions left them stale until reconnect (only amount edits were patched).
This change optimistically patches the affected total when an action runs offline, and rolls it back on failure. Supported actions:
- Submit / Retract / Unapprove (Awaiting approval): add / remove / re-add the report's reimbursable total.
- Delete / Reject (Awaiting approval, also Repaid for delete): subtract the expense's amount.
- Cancel payment (Repaid): subtract the report's total when a reimbursement is reversed.
- Create is handled via submit (new reports stay Open until submitted); edit amount was already supported.
Patches are scoped to the user's own reimbursable expenses on paid group workspaces, skipped on currency mismatch, and reconciled by the next online refresh.

Fixed Issues

$ #91370
PROPOSAL:

Tests

Offline tests

QA Steps

Prerequisites: a paid group workspace (Team/Corporate) where you are a member, and a few of your own reimbursable expenses. Each suite is run while offline (disable your network connection), starting from Home where you note the current "Your spend" totals.

Suite 1 - Awaiting approval increases

Submit an Open report with your reimbursable expenses, return to Home, and verify "Awaiting approval" increases by that report's total.
Unapprove an approved report you own and verify "Awaiting approval" increases by that report's total.

Suite 2 - Awaiting approval decreases

Retract a submitted report and verify "Awaiting approval" decreases by that report's total.
Reject a single submitted reimbursable expense and verify "Awaiting approval" decreases by that expense's amount.
Delete a single submitted reimbursable expense and verify "Awaiting approval" decreases by that expense's amount.

Suite 3 - Repaid (last 30 days)

Cancel a payment on a report you reimbursed within the last 30 days and verify "Repaid" decreases by that report's total.

Suite 4 - Rollback and reconciliation

Perform any covered action offline and force the request to fail, then verify the "Your spend" total rolls back to its previous value.
Reconnect and verify all totals reconcile with the server (no drift / no double counting).

Suite 5 - Negative checks (totals must not change)

Make a currency-only edit to an expense and verify no "Your spend" total changes.
Perform a covered action on a non-reimbursable expense and verify no total changes.
Perform a covered action on a personal/IOU (non paid-group) expense and verify no total changes.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-06-09.at.16.05.31.mov

Patch awaiting-approval and repaid snapshot search.total aggregates optimistically when money request amounts change, since Home cannot refetch those totals while offline.

Import Your spend query builders directly from @libs/YourSpendQueryUtils instead of a page-local re-export barrel, giving a single source of truth.

melvin-bot · 2026-06-09T14:47:43Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-06-09T14:47:49Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-06-09T14:54:42Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...Item/MoneyRequestReportPreview/PayActionButton.tsx	`96.55% <100.00%> (+0.06%)`	⬆️
...m/MoneyRequestReportPreview/SubmitActionButton.tsx	`97.29% <100.00%> (+0.07%)`	⬆️
...uestReportPreview/useConfirmApproveReportAction.ts	`100.00% <100.00%> (ø)`
...c/components/ReportActionItem/MoneyRequestView.tsx	`74.19% <100.00%> (+0.05%)`	⬆️
...earch/SearchList/ListItem/ReportListItemHeader.tsx	`91.89% <100.00%> (+0.11%)`	⬆️
src/components/SettlementButton/index.tsx	`82.26% <100.00%> (+0.06%)`	⬆️
src/components/YourSpendPatchDataProvider.tsx	`100.00% <100.00%> (ø)`
src/hooks/useDeleteTransactions.ts	`57.43% <100.00%> (+1.79%)`	⬆️
src/hooks/useSelectionModePayment.ts	`63.20% <100.00%> (+0.35%)`	⬆️
src/hooks/useYourSpendPatchData.ts	`100.00% <100.00%> (ø)`
... and 36 more
... and 8 files with indirect coverage changes

grgia · 2026-06-10T10:33:29Z

@adamgrzybowski lint

joekaufmanexpensify

Good for product

Replace unsafe type assertions with a typed createRandomPolicy factory and typed getSnapshotKey/buildSnapshotSearchResults helpers.

adamgrzybowski · 2026-06-11T12:42:22Z

@grgia fixed

ZhenjaHorbach · 2026-06-11T12:49:46Z

Looks like changes don't work if we reject submitted expenses
In this case, we also need to update Your spend section

2026-06-11.14.48.04.mov

adamgrzybowski · 2026-06-11T13:43:57Z

@ZhenjaHorbach Yeah, the question is how big the scope should be for this PR and which actions should be supported.

This issue is also mentioned here #93081 (comment)

ZhenjaHorbach · 2026-06-11T13:47:45Z

@ZhenjaHorbach Yeah, the question is how big the scope should be for this PR and which actions should be supported.

This issue is also mentioned here #93081 (comment)

I believe all actions should be supported, and the amount should be the same as after the response from BE

adamgrzybowski · 2026-06-11T13:55:40Z

@ZhenjaHorbach do you know exactly which actions?

create
delete
edit amount

Something else?

ZhenjaHorbach · 2026-06-11T14:07:13Z

@ZhenjaHorbach do you know exactly which actions?

create

delete

edit amount

Something else?

I suppose in the context of this flow, at least retract, unapprove, reject

adamgrzybowski · 2026-07-16T16:14:04Z

Actively working on this one

Scope the useOnyx selector to only the id, type, and outputCurrency fields the snapshot builders read, so subscribers re-render only on relevant paid-policy changes.

adamgrzybowski · 2026-07-17T14:10:48Z

@grgia ready for next steps

# Conflicts: # src/components/MoneyReportHeaderPrimaryAction/SubmitPrimaryAction.tsx # src/hooks/useHoldMenuSubmit.ts # src/libs/actions/IOU/ReportWorkflow.ts

…er main merge

github-actions · 2026-07-20T13:38:55Z

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

grgia

Confirming where we landed on this

Submitting, approving, or paying a report from the Reports page while offline can leave the Home totals stale when that report's expenses were never loaded outside search.

@adamgrzybowski do we handle search entry points? It's an edge case so NAB

github-actions · 2026-07-20T13:44:54Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #93081.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-5b266b11633-24d465b-55e74f9fa2bd3cfdd03d8e07bc4df1d577bd757d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-5b266b1-24d465b-f5139d4457835fef5fa5ee2d52109726d3027e12/index.html

Web 🕸️
https://93081.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

grgia · 2026-07-20T13:50:25Z

                        // to draft) so they can resubmit — matching the pre-submit-via-PDF behavior.
                        openPDFDownload({
                            onCancel: () =>
                                retractReport(


should we pass getYourSpendPatchData() in retractReport here too?

grgia

nab

luacmartins

The current solution feels a bit odd to me. It seems like we have all the data locally, can we just derive these values directly from the data instead of using and patching the snapshot?

An alternate solution would be to just grey out these values if any offline action is taken, but I'd confirm that approach with product first cc @trjExpensify

trjExpensify · 2026-07-20T22:03:54Z

Yeah, the alt of applying the "pending update" offline treatment seems fine for this case. It signals enough that "these totals are no longer accurate in the current state" until coming back online.

grgia · 2026-07-21T07:49:15Z

cc @JmillsExpensify on #93081 (comment)

adamgrzybowski · 2026-07-21T09:38:13Z

@grgia

@adamgrzybowski do we handle search entry points? It's an edge case so NAB

Yes

adamgrzybowski · 2026-07-21T09:45:41Z

@luacmartins

Can't derive locally. The totals come from server search snapshots that may include reports not in Onyx, so recomputing would undercount. That's why I patch the snapshot.

But yeah, we can just grey out the value instead of all this computation. Up to you

JmillsExpensify · 2026-07-21T14:50:32Z

I don't feel strongly, so defer to @luacmartins and @trjExpensify

luacmartins · 2026-07-21T16:33:42Z

I'd prefer to just grey it out and not run a bunch of complex logic that may also be incorrect given that we don't have all the data locally. I'll defer to @trjExpensify since this is mostly a product decision.

trjExpensify · 2026-07-21T21:24:46Z

Cool, sounds like we're aligned that applying "pending update" to grey out the value until coming back online will suffice. 👍

mountiny · 2026-07-21T21:42:33Z

Agree with simplicity and ui feedback here

adamgrzybowski · 2026-07-22T09:56:01Z

Okay. In that case, I guess I should close this PR and create a new one with greyed out value. Can you confirm?

mountiny · 2026-07-22T13:38:18Z

@grgia You fine with that as well?

luacmartins · 2026-07-22T16:01:35Z

Okay. In that case, I guess I should close this PR and create a new one with greyed out value. Can you confirm?

Either that or update this PR to handle that behavior

grgia · 2026-07-24T13:39:06Z

Yes we can move forward with #93081 (comment) @adamgrzybowski

grgia · 2026-07-24T13:39:21Z

Feel free to open a new pr or update this one

adamgrzybowski · 2026-07-24T13:51:15Z

@grgia the new PR is here #96966

adamgrzybowski added 2 commits June 8, 2026 17:34

Fix Your spend totals staying stale after offline expense edits.

ef190b3

Patch awaiting-approval and repaid snapshot search.total aggregates optimistically when money request amounts change, since Home cannot refetch those totals while offline.

Remove redundant YourSpendSection queries barrel

fabd3fd

Import Your spend query builders directly from @libs/YourSpendQueryUtils instead of a page-local re-export barrel, giving a single source of truth.

adamgrzybowski requested review from a team as code owners June 9, 2026 14:47

melvin-bot Bot assigned adamgrzybowski Jun 9, 2026

melvin-bot Bot requested review from ZhenjaHorbach and joekaufmanexpensify and removed request for a team June 9, 2026 14:47

melvin-bot Bot requested review from a team and grgia and removed request for a team June 9, 2026 14:47

Remove unused exports from YourSpendSnapshotUpdate

3545edc

grgia reviewed Jun 10, 2026

View reviewed changes

Comment thread src/libs/actions/IOU/UpdateMoneyRequest.ts Outdated

grgia reviewed Jun 10, 2026

View reviewed changes

Comment thread src/libs/actions/IOU/YourSpendSnapshotUpdate.ts

joekaufmanexpensify previously approved these changes Jun 10, 2026

View reviewed changes

adamgrzybowski added 2 commits June 11, 2026 12:09

Fix ESLint no-unsafe-type-assertion errors in Your spend snapshot test

d767640

Replace unsafe type assertions with a typed createRandomPolicy factory and typed getSnapshotKey/buildSnapshotSearchResults helpers.

Patch Your spend totals only for amount edits, not currency changes

215db73

adamgrzybowski dismissed joekaufmanexpensify’s stale review via 215db73 June 11, 2026 11:12

Merge branch 'main' into @adamgrzybowski/fix-offline-your-spend

009264f

adamgrzybowski added 2 commits July 17, 2026 13:21

Narrow paid-group policy selector to Your spend fields

231d923

Scope the useOnyx selector to only the id, type, and outputCurrency fields the snapshot builders read, so subscribers re-render only on relevant paid-policy changes.

Merge branch 'main' into @adamgrzybowski/fix-offline-your-spend

5b07439

adamgrzybowski mentioned this pull request Jul 17, 2026

[$250] Receipt hover preview zoom opens on the wrong side of the thumbnail #95975

Open

7 tasks

adamgrzybowski added 2 commits July 20, 2026 12:47

Merge remote-tracking branch 'eorigin/main' into cursor/9e17752f

4393d0c

# Conflicts: # src/components/MoneyReportHeaderPrimaryAction/SubmitPrimaryAction.tsx # src/hooks/useHoldMenuSubmit.ts # src/libs/actions/IOU/ReportWorkflow.ts

Add iouReportOwnerLogin to getUpdateMoneyRequestParams test calls aft…

5b266b1

…er main merge

adamgrzybowski force-pushed the @adamgrzybowski/fix-offline-your-spend branch from 4254814 to 5b266b1 Compare July 20, 2026 10:47

grgia approved these changes Jul 20, 2026

View reviewed changes

grgia reviewed Jul 20, 2026

View reviewed changes

grgia approved these changes Jul 20, 2026

View reviewed changes

luacmartins reviewed Jul 20, 2026

View reviewed changes

adamgrzybowski closed this Jul 24, 2026

adamgrzybowski mentioned this pull request Jul 24, 2026

[Home Page] Fix: Your spend section does not update after updating expense offline V2 - Greyed out #96966

Open

40 tasks

Uh oh!

Conversation

adamgrzybowski commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 9, 2026

Uh oh!

melvin-bot Bot commented Jun 9, 2026

Uh oh!

codecov Bot commented Jun 9, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

grgia commented Jun 10, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

adamgrzybowski commented Jun 11, 2026

Uh oh!

ZhenjaHorbach commented Jun 11, 2026

Uh oh!

adamgrzybowski commented Jun 11, 2026

Uh oh!

ZhenjaHorbach commented Jun 11, 2026

Uh oh!

adamgrzybowski commented Jun 11, 2026

Uh oh!

ZhenjaHorbach commented Jun 11, 2026

Uh oh!

adamgrzybowski commented Jul 16, 2026

Uh oh!

adamgrzybowski commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 20, 2026

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 20, 2026

Uh oh!

grgia Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

trjExpensify commented Jul 20, 2026

Uh oh!

grgia commented Jul 21, 2026

Uh oh!

adamgrzybowski commented Jul 21, 2026

Uh oh!

adamgrzybowski commented Jul 21, 2026

Uh oh!

JmillsExpensify commented Jul 21, 2026

Uh oh!

luacmartins commented Jul 21, 2026

Uh oh!

trjExpensify commented Jul 21, 2026

Uh oh!

mountiny commented Jul 21, 2026

Uh oh!

adamgrzybowski commented Jul 22, 2026

Uh oh!

mountiny commented Jul 22, 2026

Uh oh!

adamgrzybowski commented Jun 9, 2026 •

edited

Loading

codecov Bot commented Jun 9, 2026 •

edited by github-actions Bot

Loading

luacmartins left a comment •

edited

Loading

adamgrzybowski commented Jul 24, 2026 •

edited

Loading