[TESTING ONLY] Pin react-native-onyx to #814 (classify Failed to write blobs as INVALID_DATA)#96957
Draft
elirangoshen wants to merge 1 commit into
Draft
[TESTING ONLY] Pin react-native-onyx to #814 (classify Failed to write blobs as INVALID_DATA)#96957elirangoshen wants to merge 1 commit into
elirangoshen wants to merge 1 commit into
Conversation
… HEAD Swap to the published version once the Onyx PR is merged and released. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
42 tasks
Contributor
|
|
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Testing/bump PR for Expensify/react-native-onyx#814 (classify
Failed to write blobsIndexedDB errors asINVALID_DATAso they are never retried — the dead blob can never serialize, so the 5× bounded retry per write is pure noise).Per the Onyx PR contract, this PR pins
react-native-onyxto the Onyx PR's HEAD (callstack-internal/react-native-onyx#fcfaf4e8) so the full E/App test suite runs against it. Once Onyx #814 is merged and published, this PR swaps to the released version and becomes the bump PR.The only change is
package.json/package-lock.json.Fixed Issues
$ #87844
$ #87871
PROPOSAL:
Tests
npm installand verifynode_modules/react-native-onyx/dist/storage/providers/IDBKeyValProvider/classifyError.jscontains thefailed to write blobs→INVALID_DATAbranch.Offline tests
None — dependency pin only; offline behavior is covered by the standard test suite against the pinned ref.
QA Steps
Same as Tests (step 2).
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari