Facelift: hover/active colors and section spacing#96989
Draft
shawnborton wants to merge 1 commit into
Draft
Conversation
melvin-bot
Bot
requested review from
JmillsExpensify
and removed request for
a team
July 24, 2026 16:45
|
@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
shawnborton
marked this pull request as draft
July 24, 2026 16:46
Contributor
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
JmillsExpensify
left a comment
Contributor
There was a problem hiding this comment.
No product review required on this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Facelift pass on hover/active/selected states and content-card spacing:
highlightBG(product200) and selected/active useshoverComponentBG(product300). Added an opt-inhoverBackgroundColorprop plus aMenuItemHoverBackgroundContextso MenuItems rendered inside a container card (Section) hover at product300 to stand out from the product200 card background.OptionRowLHNhover → product200, selected → product300 (scoped, does not affect shared selection-list/member-table styles).SearchTypeMenuItemhover → product200, selected → product300.TabSelectoractive tab background → product300 (hoverComponentBG); inactive/hover unchanged.sectionMargin16 → 20 (card horizontal padding) andworkspaceSectionMaxWidth680 → 740; wrapper maxWidth recomputes to 780.Note: this branch also carries earlier content-centering work (
workspaceSectionCentered,centeredContentWidthLimiter) across Account / Workspace / Domain pages.Fixed Issues
$
PROPOSAL:
Tests
Offline tests
Styling-only change; no offline-specific behavior.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari