Skip to content

Facelift: hover/active colors and section spacing#96989

Draft
shawnborton wants to merge 1 commit into
mainfrom
shawn-facelift
Draft

Facelift: hover/active colors and section spacing#96989
shawnborton wants to merge 1 commit into
mainfrom
shawn-facelift

Conversation

@shawnborton

Copy link
Copy Markdown
Contributor

Explanation of Change

Facelift pass on hover/active/selected states and content-card spacing:

  • MenuItem: hover background now uses highlightBG (product200) and selected/active uses hoverComponentBG (product300). Added an opt-in hoverBackgroundColor prop plus a MenuItemHoverBackgroundContext so MenuItems rendered inside a container card (Section) hover at product300 to stand out from the product200 card background.
  • LHN (Inbox): OptionRowLHN hover → product200, selected → product300 (scoped, does not affect shared selection-list/member-table styles).
  • Spend LHN: SearchTypeMenuItem hover → product200, selected → product300.
  • Tabs: TabSelector active tab background → product300 (hoverComponentBG); inactive/hover unchanged.
  • Home widgets: MenuItems inside home widgets keep product300 hover via the explicit prop.
  • Section spacing: sectionMargin 16 → 20 (card horizontal padding) and workspaceSectionMaxWidth 680 → 740; wrapper maxWidth recomputes to 780.

Note: this branch also carries earlier content-centering work (workspaceSectionCentered, centeredContentWidthLimiter) across Account / Workspace / Domain pages.

Fixed Issues

$
PROPOSAL:

Tests

  1. Open the Inbox LHN, Spend LHN, and any tab bar (Inbox header tabs, Workspaces, Create Expense flow): hover a row/tab and verify the hover background is product200; verify the active/selected row/tab is product300.
  2. Open Account > Profile and Workspace > Overview: hover a MenuItem row inside a card and verify the hover background (product300) stands out from the card background.
  3. Verify content cards on those pages have 20px horizontal padding and a 740px content max width.
  4. Verify that no errors appear in the JS console

Offline tests

Styling-only change; no offline-specific behavior.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@shawnborton
shawnborton requested review from a team as code owners July 24, 2026 16:44
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and removed request for a team July 24, 2026 16:45
@melvin-bot
melvin-bot Bot requested a review from cristipaval July 24, 2026 16:46
@melvin-bot

melvin-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team July 24, 2026 16:46
@shawnborton
shawnborton marked this pull request as draft July 24, 2026 16:46
@github-actions

Copy link
Copy Markdown
Contributor

🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96989.

Android 🤖 iOS 🍎
❌ FAILED ❌ https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4daf536-beddf69-374dfdca18f02df54564294aaf02b7246b0c1459/index.html
The QR code can't be generated, because the Android build failed iOS
Web 🕸️
https://96989.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No product review required on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants