Add View on Spend button to Travel Invoicing settings#97011
Open
ishpaul777 wants to merge 3 commits into
Open
Conversation
Links admins to the Spend page pre-filtered on the Consolidated Travel Billing feed so they can reconcile travel spend. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
ishpaul777
marked this pull request as ready for review
July 24, 2026 22:50
melvin-bot
Bot
requested review from
Eskalifer1 and
dannymcclain
and removed request for
a team
July 24, 2026 22:50
|
@dannymcclain @Eskalifer1 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
requested review from
flaviadefaria
and removed request for
a team
July 24, 2026 22:50
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The `{fundID}_{BANK}_{PROGRAM_TRAVEL_US}` feed-ID string was built inline in
WorkspaceTravelInvoicingSection and useGetExpensifyCardFromReportAction. Extract
a getTravelInvoicingFeedID helper in TravelInvoicingUtils and reuse it in both,
so the format lives in one place.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Eskalifer1
reviewed
Jul 25, 2026
Eskalifer1
left a comment
Eskalifer1
left a comment
Contributor
There was a problem hiding this comment.
Hi, I logged in to my account, where I'm added to the “Test Travel External” workspace, and when I click this button, I should, in theory, only see feed: Consolidated Travel billing, based on this comment:
But for some reason, Expensify Card is also being added—which is expected—yet that specific value isn't shown in the pop-up? Is this a bug?
2026-07-25.14.28.23.mov
Eskalifer1
reviewed
Jul 25, 2026
Eskalifer1
left a comment
Eskalifer1
left a comment
Contributor
There was a problem hiding this comment.
On a device that's a little over 800px wide, when using a language like Netherlands, the display is very poor—what do you think about that?
2026-07-25.14.35.40.mov
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Adds a View on Spend button to the Current travel spend row in the Travel Invoicing (Consolidated Travel Billing) settings section. It navigates to the Spend page with a pre-filled query filtered on the Consolidated Travel Billing feed, so admins can drill into and reconcile their travel spend instead of relying on the static PDF statement.
The feed filter uses the Travel Invoicing feed ID (
{fundID}_Expensify Card_TRAVEL_US), built viabuildQueryStringFromFilterFormValuesand routed throughROUTES.SEARCH_ROOT. Per the issue discussion, the query filters on the feed only — no workspace filter.Fixed Issues
$ #96215
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screen.Recording.2026-07-25.at.4.17.02.AM.mov