Skip to content

Fix insufficient spacing between card name and issue card button on resize #97018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MobileMage wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −7
Draft

Fix insufficient spacing between card name and issue card button on resize #97018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,12 +208,7 @@ function WorkspaceExpensifyCardListPage({route, cardsList, fundID}: WorkspaceExp
]
: [];
const getHeaderButtons = () => {
const headerButtonsRowStyle = [
styles.flexRow,
styles.gap2,
!shouldShowSelector && shouldDisplayButtonsInSeparateLine && styles.mb3,
shouldShowSelector && shouldDisplayButtonsInSeparateLine && styles.mt3,
];
const headerButtonsRowStyle = [styles.flexRow, styles.gap2, !shouldShowSelector && shouldDisplayButtonsInSeparateLine && styles.mb3];

const shouldShowBulkSelectionDropdown = shouldUseNarrowLayout ? isMobileSelectionModeEnabled : selectedCardIDs.length > 0;

Expand Down Expand Up @@ -310,7 +305,15 @@ function WorkspaceExpensifyCardListPage({route, cardsList, fundID}: WorkspaceExp
</HeaderWithBackButton>
{!shouldShowSelector && shouldDisplayButtonsInSeparateLine && isBankAccountVerified && shouldShowHeaderButtons && <View style={styles.ph5}>{getHeaderButtons()}</View>}
{shouldShowSelector && (
<View style={[styles.w100, styles.ph5, styles.pb3, (!shouldChangeLayout || isInLandscapeMode) && [styles.flexRow, styles.alignItemsCenter, styles.justifyContentBetween]]}>
<View
style={[
styles.w100,
styles.ph5,
styles.pb3,
styles.gap3,
(!shouldChangeLayout || isInLandscapeMode) && [styles.flexRow, styles.alignItemsCenter, styles.justifyContentBetween],
]}
>
<FeedSelector
wrapperStyle={isInLandscapeMode ? styles.flex1 : undefined}
onFeedSelect={() => Navigation.navigate(createDynamicRoute(DYNAMIC_ROUTES.WORKSPACE_EXPENSIFY_CARD_SELECT_FEED.path))}
Expand Down
Loading