Slice 2: postCodeReviewResults.sh + run-claude-action composite#68
Draft
kacper-mikolajczak wants to merge 2 commits into
Draft
Slice 2: postCodeReviewResults.sh + run-claude-action composite#68kacper-mikolajczak wants to merge 2 commits into
kacper-mikolajczak wants to merge 2 commits into
Conversation
Centralises the violations post-processing loop currently duplicated across Expensify/App, Expensify/Auth, and Expensify/Web-Expensify's claude-review.yml workflows. The script reads STRUCTURED_OUTPUT from env, adds a +1 reaction when there are no violations, and otherwise posts one inline comment per violation via createInlineComment.sh.
Single composite step pinning anthropics/claude-code-action@ba026a3e (v1.0.86) with common defaults: anthropic_api_key, github_token, allowed_non_write_users ("*"), display_report ("true"). Model selection lives in claude_args - App passes --model claude-opus-4-6 explicitly; Auth and Web-Expensify rely on the CLI default (Sonnet today).
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Slice 2 of the Claude reviewer centralisation effort. Two additions, both designed so the client
claude-review.ymlworkflows collapse the duplication that remained after slice 1.1.
claude-review-toolkit/scripts/postCodeReviewResults.sh- centralises the violations post-processing loop currently duplicated across all three client workflows. ReadsSTRUCTURED_OUTPUTfrom env, takesPR_NUMBERas positional arg, posts a+1reaction on zero violations or N inline comments viacreateInlineComment.shotherwise. EmptySTRUCTURED_OUTPUT->::error::+ exit 1.2.
run-claude-actioncomposite action - pinsanthropics/claude-code-action@ba026a3e(v1.0.86) at a single place. Inputs:anthropic_api_key,github_token,prompt(required);claude_args,allowed_non_write_users(default*),display_report(default"true") (optional). Output:structured_outputpassthrough. Model selection lives inclaude_argsper caller because today's three client repos disagree (App: explicit--model claude-opus-4-6; Auth & Web: CLI default Sonnet).Related Issues
https://github.com/Expensify/Expensify/issues/635397
Manual Tests
postCodeReviewResults.shsmoke-tested locally with mockedaddPrReaction.sh/createInlineComment.shonPATH:+1reaction callSTRUCTURED_OUTPUT->::error::+ exit 1PR_NUMBER-> usage error + exit 1run-claude-action: end-to-end exercised via the three client adoption PRs linked below.Linked PRs
Client adoption PRs (drafts; reference this PR by placeholder SHA, re-stamped on merge):