[No QA] Node-integration SQLite tests via better-sqlite3#794
Draft
sosek108 wants to merge 3 commits into
Draft
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c627f8414
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Adds Node-side integration tests for
SQLiteProviderso the SQLite storage path is covered in CI on every PR, instead of relying on manual device runs to catch SQL-shaped regressions. Until now, the provider had no real test coverage: unit tests stub out the database, and bugs in query strings, parameter binding, merge semantics, or escaping only surfaced once the code hit a real engine on device — late, expensive, and easy to miss. Running the actual provider against a real SQL engine in Node closes that gap at zero infrastructure cost: failures show up in seconds on the same CI that already runs the rest of the suite, refactors to the SQL layer become safe to make, and the contract betweenSQLiteProviderand the underlying database (merge behavior, null handling, injection safety, batch semantics) is now pinned down by executable tests rather than tribal knowledge.Related Issues
Expensify/App#91861
Linked E/App PR
Expensify/App#91959
Automated Tests
This PR introduces integration tests in
SQLiteProviderTest.ts. This is new file and contains same tests asIDBKeyvalProviderTest.tsfor different provider.Manual Tests
None. This PR adds automated testing only.
Author Checklist
### Related Issuessection above### Linked E/App PRsection above, and verified this change against it (E/App CI passed and manual testing completed)TestssectiontoggleReportand notonIconClick)myBool && <MyComponent />.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Avataris modified, I verified thatAvataris working as expected in all cases)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari