Handle more windows opening and update maximum version to 138.*#4
Handle more windows opening and update maximum version to 138.*#4WoofGrrrr wants to merge 3 commits intoExtended-Thunder:mainfrom
Conversation
I have been using this with 138.a01 (Daily) for over a week with no problems.
|
Thanks for this! Can you explain why addressbook/addressbook is removed in your patch? Is this because the addressbook no longer exists as a separate window in the current version of Thunderbird? If so, then when was that change made, e.g., is it possible that it's still a separate window in TB128, which the add-on should still support? |
|
My pleasure. Yes, Address Book is now a Tab in the main window. I cannot say exactly when that change was made, but I know for sure at least by 128. I have been using my version of userChromeJS with 128 and before. It think the change to Address Book was before that. I think SuperNova, 115. You may be seeing that my fork was created only recently because I learned about GitHub and how to fork and submit a pull request only very recently. Before then I just copied the .xpi file, un-zipped it, altered it, re-zipped it, and installed again from that .xpi file. But now, as you have seen, things get more difficult with the Security Restrictions of the Release Channel. I do now finally see the point. I hadn't considered that I was exposing myself to malicious content in received email. |
I commented in my review on the Thunderbird Add-ons page that I had this working with more windows. And I got an email reply, suggesting I do a pull request. I took some time to learn what a pull is and get comfortable with it. So here it is.
And, oh, I've updated the manifest to set strict_max_version to 138.* and I have been using it with Thunderbird Daily for over a week.
I've been using these changes for just short of a year. I do a lot of stuff in my userChrome.js now.
I have a "skeleton" userChrome.js that doesn't really do anything, but it run the checks to see exactly which window has opened and logs it. And if it encounters a window it doesn't handle, it logs all the information for that window to make it easy to update the script to detect it. I can add this to the pull request if you think it might be useful to someone else.