Skip to content

fix: default max_items to 1 at runtime to prevent unbounded batch fan-out #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chubes4 merged 1 commit into from
Mar 3, 2026
Merged

fix: default max_items to 1 at runtime to prevent unbounded batch fan-out #570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions inc/Core/Steps/Fetch/Handlers/FetchHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,10 @@ final public function get_fetch_data( int|string $pipeline_id, array $handler_co
// Items without dedup_key pass through unchanged.
$items = $this->dedup( $items, $context );

// Apply max_items cap when configured.
$max_items = (int) ( $config['max_items'] ?? 0 );
// Apply max_items cap.
// Default to 1 to prevent unbounded fan-out when flows lack an
// explicit max_items value. Set to 0 for unlimited.
$max_items = (int) ( $config['max_items'] ?? 1 );
if ( $max_items > 0 && count( $items ) > $max_items ) {
$items = array_slice( $items, 0, $max_items );
}
Expand Down
Loading