Skip to content

Handle empty vast in vmap #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lunkers merged 3 commits into from
Aug 19, 2025
Merged

Handle empty vast in vmap #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a00774
Merge branch 'performant-decode'
CarlLindqvist Jun 19, 2025
48717bf
Merge remote-tracking branch 'upstream/main'
CarlLindqvist Aug 19, 2025
121c50b
Handle empty vast inside vmap
CarlLindqvist Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions vmap/decoder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,9 @@ func (adBreak *AdBreak) UnmarshalToken(tok *xmltokenizer.Tokenizer, se *xmltoken
switch string(token.Name.Local) {
case "VAST":
var vast VAST
if token.SelfClosing {
break
}
// Reuse Token object in the sync.Pool since we only use it temporarily.
se := xmltokenizer.GetToken().Copy(token)
err = vast.UnmarshalToken(tok, se)
Expand Down
14 changes: 14 additions & 0 deletions vmap/sample-vmap/testVmapEmptyVast.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<vmap:VMAP version="1.0" xmlns:vmap="http://www.iab.net/vmap-1.0">
<vmap:AdBreak breakId="midroll.ad-1" breakType="linear" timeOffset="start">
<vmap:AdSource id="1" allowMultipleAds="true" followRedirects="true">
<vmap:VASTAdData>
<VAST version="4.1" />
</vmap:VASTAdData>
</vmap:AdSource>
<vmap:TrackingEvents>
<vmap:Tracking event="breakStart"><![CDATA[
http://test-adserver.domain/api/v1/sessions/331cea0b-f9a0-4ad3-b07c-e552f003316d/tracking?adId=midroll.ad-3&progress=vmap
]]></vmap:Tracking>
</vmap:TrackingEvents>
</vmap:AdBreak>
</vmap:VMAP>
11 changes: 11 additions & 0 deletions vmap/structure_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,17 @@ func TestDecodeEmptyVmap(t *testing.T) {
is.Equal(len(vmap.AdBreaks), 0)
}

func TestDecodeVmapEmptyVast(t *testing.T) {
is := is.New(t)
doc, err := os.ReadFile("sample-vmap/testVmapEmptyVast.xml")
is.NoErr(err)

vmap, err := DecodeVmap(doc)
is.NoErr(err)

is.Equal(len(vmap.AdBreaks), 1)
}

func TestDecodeEmptyVast(t *testing.T) {
is := is.New(t)
doc, err := os.ReadFile("sample-vmap/testVast3.xml")
Expand Down
Loading