Skip to content

Fill empty VAST data with empty VAST object instead of nil #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lunkers merged 1 commit into from
Aug 19, 2025
Merged

Fill empty VAST data with empty VAST object instead of nil #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions vmap/decoder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ func (adBreak *AdBreak) UnmarshalToken(tok *xmltokenizer.Tokenizer, se *xmltoken
case "VAST":
var vast VAST
if token.SelfClosing {
adBreak.AdSource.VASTData.VAST = &VAST{}
break
}
// Reuse Token object in the sync.Pool since we only use it temporarily.
Expand Down
1 change: 1 addition & 0 deletions vmap/structure_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ func TestDecodeVmapEmptyVast(t *testing.T) {
is.NoErr(err)

is.Equal(len(vmap.AdBreaks), 1)
is.Equal(len(vmap.AdBreaks[0].AdSource.VASTData.VAST.Ad), 0)
}

func TestDecodeEmptyVast(t *testing.T) {
Expand Down
Loading