Skip to content
Tom edited this page Aug 13, 2019 · 1 revision

Here is a list of common problems.

I can't push to master

That is the purpose. We don't know if your code works and master should always work. Because of this you need to fork the project and create a pull request. The pull request will then be verified by our tools

During a pull request a check failed

This project verifies if your code is following the shellcheck guidelines. These are the checks we perform

shellcheck --exclude=SC1090,SC2034,SC1091 shunit
shellcheck --exclude=SC2034,SC1090,SC1091,SC2145 assert.sh

Please make sure those don't output anything. If they do the build will fail. After those checks are complete a TU will check your pull request and they will merge it or provide a comment telling you why the pull request will be closed

All the checks succeeded on my pull request but I still can't merge

This is because we only allow commits that are signed with a gpg key. Here is more information on the subject The reason we use gpg is to verify the user pushing the commit. If something ever goes wrong we can contact the real commiter to fix that bug asap (if we can't fix it)

Clone this wiki locally