Add assignment time lobby option#28
Open
JeroenDeDauw wants to merge 1 commit into
Open
Conversation
This allows hosts to change the assignment time via lobby options. In some cases, such using prebuild or on as small maps, it does not make sense to wait a whole 8 minutes for the assignment. The new option allows for much quicker assignment without changing the default.
JeroenDeDauw
force-pushed
the
add-assign-time-option
branch
from
8795010 to
edb2d32
Compare
Member
|
@JeroenDeDauw I think there is not much activity on Phantom mod. Maybe you want to join your Zulip(chat service) we can send you an invite |
Contributor
Author
|
@axel1200 thanks. Maybe you can link these two PR there if that is what is needed? |
Member
|
They have been linked but nobody feels responsible I guess. |
Contributor
Author
Collaborator
|
The timer does not reflect the option selected. Not sure if the author is still active, if not i will deal with this later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows hosts to change the assignment time via lobby options.
In some cases, such using prebuild or on as small maps, it does not make sense to wait
a whole 8 minutes for the assignment. The new option allows for much quicker assignment
without changing the default.