Upgrade pylance to 8.0.0; blob-table compaction now works#11
Merged
Conversation
pylance 8.0.0 ships the fix for lance-format/lance#7071 (blob v2 tables failed to compact inside the decoder), verified against both the minimal repro and a daft-lance-written table with null blobs. - Pin pylance>=8.0.0. - manage.py: compaction is no longer best-effort — the try/except added when blob tables could not be compacted is removed. The explicit compaction_options={} stays: that works around a separate lance-ray 0.4.x defect (lance-format/lance-ray#5224). - Promote the hermetic local_ray fixture to tests/conftest.py and attach it to every test that reaches Ray through compact_files, since delete_by_date once again hard-depends on Ray. - Add test_delete_and_compact_blob_table: regression test compacting a daft-lance-written blob v2 table — raises on pylance 7.x. - README: replace the "blob tables cannot be compacted" limitation with the version requirement; bump verified pylance version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pylance 8.0.0 (released 2026-07-01) ships the fix for lance-format/lance#7071 — compaction of blob v2 tables (what daft-lance
blob_columnswrites, i.e. both asset tables) previously failed inside lance's decoder. Verified in isolated envs before upgrading: both the minimal pure-pylance repro and a daft-lance-written table with null blobs now compact correctly, with blobs readable afterwards.Changes
pylance>=8.0.0(7.0.0 → 8.0.0; daft-lance/lance-ray resolve cleanly).manage.py: compaction is no longer best-effort. The try/except +[warn]downgrade existed only because blob tables could not be compacted; deletion-triggered compaction failures should be loud again. The explicitcompaction_options={}stays — that works around a separate lance-ray 0.4.x defect (lance-format/lance-ray#5224, fix pending in #5225).local_ray(hermetic local cluster) promoted totests/conftest.py(module-scoped) and attached to every test reaching Ray viacompact_files, sincedelete_by_datehard-depends on Ray again. Newtest_delete_and_compact_blob_tablecompacts a daft-lance-written blob v2 table — a regression test that raises on pylance 7.x.pylance ≥ 8.0.0requirement; verified-versions table bumped.Testing
Note: may conflict trivially with the
media-workflow-reorgbranch in README; whichever merges second rebases.