fix spree_nav_cache_key change every time bug#1
Open
AriseshineSky wants to merge 2 commits intomasterfrom
Open
fix spree_nav_cache_key change every time bug#1AriseshineSky wants to merge 2 commits intomasterfrom
AriseshineSky wants to merge 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
current_store is an object, and it is an instance of Spree::Store. current_store.to_s return Spree::Store and an encoding of the object id. The object id changes in every request, so does the cache key.
Every field and attachment of store changes, it will update current store's updated_at. So current_store.updated_at can be used as cache key.