Open
Conversation
krofna
requested changes
Aug 3, 2021
Member
krofna
left a comment
krofna
left a comment
There was a problem hiding this comment.
I skimmed over it, haven't tested yet. Apart from one comment I've made it seems fine. btw: what kind of script files should i expect in mpk? are they compatible with nss/nsb?
| return nullptr; | ||
|
|
||
| MpkEntry* MPKEntry = (MpkEntry*)iter->second; | ||
| uint8_t* buffer = new uint8_t[Size]; |
Member
There was a problem hiding this comment.
Alloc parameter should be used instead of new.
Author
|
afaik it uses a new script format, haven't looked into it much yet though. https://github.com/CommitteeOfZero/impacto is a new project with a larger scope btw, found it only after making this PR lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(for steins;gate steam version)