Conversation
…bership-url-oauth-support
| client = clientBuilder.build(); | ||
| awsSecurityTokenService = stsBuilder.build(); | ||
| jCredStash = new JCredStash(ddbBuilder.build(), kmsBuilder.build(), awsSecurityTokenService); | ||
| if(envConfig.hasProxyEnv()) { |
There was a problem hiding this comment.
Not sure if I understand this if condition, don't we have to initialize all the clients if proxy env is provided and if not provided, like if.....else....
There was a problem hiding this comment.
We're still building the Clients on lines 128-131. For AWS SDK v2, client builders like the DynamoDbClientBuilder need an additional HTTP Client built-in for proxy configuration to work. The if-block there takes care of that if proxy configuration is provided but skips if it's not.
| protected AWSSecurityTokenService awsSecurityTokenService; | ||
| protected DynamoDB dynamoDB; | ||
| protected StsClient stsClient; | ||
| protected static List<String> TABLE_HEADERS = Arrays.asList("name", "component", "sdlc", "contents", "version", "updatedBy", "updatedOn", "key", "hmac", "source", "sourceType"); |
There was a problem hiding this comment.
Unused variable. You can remove it
There was a problem hiding this comment.
Good catch. Will remove.
| } | ||
|
|
||
| // Creates a new DynamoDBMapper object | ||
| public DynamoDBMapper createMapper(String account, String region, String tableName) { |
There was a problem hiding this comment.
DynamoDBMapper is no longer supported in SDK v2. Needed to do some workarounds to keep the logic as is.
| @@ -78,44 +78,60 @@ | |||
| </developers> | |||
There was a problem hiding this comment.
Can we update the maven compiler plugin to line up with this PR? #65
3 participants
Performed local testing using GETs, PUTs, DELETEs. Performed a couple secret rotations, pulled credential history, updated metadata.