installer: fix Inno Setup [Code] comment closing early on {app}#451
Merged
Conversation
The uninstall comment contained "{app}", and in Inno Setup's Pascal [Code]
{ } are comment delimiters -- so the } in {app} closed the comment early and
the following text parsed as code, failing ISCC with "line 178: Identifier
expected". This only surfaced at release time (ISCC never runs otherwise), so
the v0.1.3 windows-installers job failed. Reword the comment to avoid braces.
Add .github/workflows/installer-check.yml: on any installer/** change it runs
ISCC against pasclaw.iss (both arches, dummy payload) so a script/[Code]
syntax error is caught at PR time instead of only during a release.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LGQKz579j1ZnDRwmr6h1V6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure
The v0.1.3 release's
windows-installersjob failed:Cause
The uninstall step's comment contained
{app}. In Inno Setup's Pascal[Code],{ }are comment delimiters — so the}inside{app}closed the comment early, and the text after it (to exactly one hive…) was parsed as code → "Identifier expected". ISCC only runs at release time (never in the normal FPC/Delphi builds), so this slipped through PR #449 and only surfaced when v0.1.3 was published.Fix
{app}in[Code]comments)..github/workflows/installer-check.yml: on anyinstaller/**change, compilepasclaw.isswith ISCC (both arches, dummy payload) so a script/[Code]syntax error is caught at PR time instead of during a release. This PR exercises that check on itself.Re-releasing v0.1.3
Once this is merged to
main, re-run Release artifacts → Run workflow with tagv0.1.3(thePasClaw-x64.exe/PasClaw-x86.exeare already attached to the release, so it just repackages). The Linux tarballs from the failed run already uploaded fine.🤖 Generated with Claude Code
Generated by Claude Code