Address code-review findings from PRs #460–#465#466
Merged
Conversation
Follow-ups to the review of the workflow + Delphi/Linux portability work: - gateway (#461): append the disconnect-abort hook instead of replacing LoopCfg.Hooks, so any hooks set upstream survive; document that BeforeTurn aborts before the next model turn (not mid-tool). Guard HandleSteer's body Parse so a malformed steer body returns 400, not a 500. - workflow (#463): ResolveWorkflowOutputs gains an overload that reports which output templates failed to resolve; workflow_run surfaces them under "output_errors" instead of silently returning an empty value. - workflow (#465): document in workflow_save that a loop re-runs the whole DAG each pass (N× paid-node cost) and list the exact "until" markers that stop it early. Add a workflow_tests case proving the until-condition stops the loop before max. - cliui (#460): comment the bare/unknown-platform echo-off fallback guard. - webui (#464): reserve a left gutter so auto-placed nodes never land under the fixed INPUT box. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGQKz579j1ZnDRwmr6h1V6
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes from the review of the workflow + Delphi/Linux portability work. One commit; all changes build clean (
make all) andmake test-workflowpasses (including a newuntilearly-stop case).Changes
Gateway (#461)
LoopCfg.Hooks := LoopCfg.Hooks + [AbortHook]) instead of replacing the array, so any hooks set upstream survive. Added a comment notingBeforeTurnaborts before the next model turn (not mid-tool).HandleSteer's bodyParseso a malformed steer body returns a clean400instead of raising into a500(other handlers already wrapParse; this one didn't).Workflow engine (#463)
ResolveWorkflowOutputsoverload reports which declared output templates failed to resolve;workflow_runsurfaces them underoutput_errorsinstead of silently returning an empty value, so a mistyped selector is diagnosable.Workflow tooling / tests (#465)
workflow_savedescription now warns that a loop re-runs the whole DAG each pass (N× paid-node cost) and lists the exactuntilmarkers that stop it early (true / yes / done / 1 / stop / complete).TestLoopUntilproving theuntilcondition stops the loop beforemax.CliUI (#460)
{$IF}), naming what it targets.Web UI (#464)
IO_GUTTER) so auto-placed nodes never land under the fixed INPUT box at (8,8). Regeneratedwebui.res.Verification
make alllinks clean — both changed Pascal units (PasClaw.Gateway.Server,PasClaw.Workflow.Tools) recompiled.make test-workflow→workflow_tests: OK.Not covered here
Posix.Termiosnames,setenvexternal) still need a realdccLinux64 compile to confirm — that can't be done in this FPC-only environment.🤖 Generated with Claude Code
https://claude.ai/code/session_01LGQKz579j1ZnDRwmr6h1V6
Generated by Claude Code